[U-Boot] [PATCH 1/2] imx: imx6sx-sdb: Enable DM QSPI driver

Ye Li ye.li at nxp.com
Wed Jun 27 13:46:00 UTC 2018


On 6/27/2018 6:28 PM, Jagan Teki wrote:
> On Wed, Jun 27, 2018 at 3:29 PM, Fabio Estevam <festevam at gmail.com> wrote:
>> Hi Ye Li,
>>
>> On Wed, Jun 27, 2018 at 3:48 AM, Ye Li <ye.li at nxp.com> wrote:
>>> To support DM QSPI driver
>>>  - Add spi0 and spi1 alias for qspi1 and qspi2.
>>>  - Modify n25q256a at 0 and n25q256a at 1 compatible string to "spi-flash"
>>>  - Enable DM SPI/QSPI relavent configurations
>>>  - Remove iomux settings of qspi2 in board codes which is not needed
>>>    for DM driver.
>>>  - Add sf default settings. So running "sf probe" can detect the flash
>>>
>>> Signed-off-by: Ye Li <ye.li at nxp.com>
>>> ---
>>>  arch/arm/dts/imx6sx-sdb.dts                 |  4 ++--
>>>  arch/arm/dts/imx6sx.dtsi                    | 12 +++++++-----
>>>  board/freescale/mx6sxsabresd/mx6sxsabresd.c | 25 -------------------------
>>>  configs/mx6sxsabresd_defconfig              |  7 +++++++
>>>  include/configs/mx6sxsabresd.h              |  4 ++++
>>>  5 files changed, 20 insertions(+), 32 deletions(-)
>>>
>>> diff --git a/arch/arm/dts/imx6sx-sdb.dts b/arch/arm/dts/imx6sx-sdb.dts
>>> index 6dd9beb..a04b00d 100644
>>> --- a/arch/arm/dts/imx6sx-sdb.dts
>>> +++ b/arch/arm/dts/imx6sx-sdb.dts
>>> @@ -115,7 +115,7 @@
>>>         flash0: n25q256a at 0 {
>>>                 #address-cells = <1>;
>>>                 #size-cells = <1>;
>>> -               compatible = "micron,n25q256a", "jedec,spi-nor";
>>> +               compatible = "spi-flash";
>>
>> I don't see "spi-flash" compatible documented in the kernel bindings.
>>
>> Please clarify why we are deviating from Linux here.
> 
> We still not sync with Linux on this area, better to append or add
> -u-boot.dtsi for this change. will remove once synced.
> 
I will move it to imx6sx-sdb-u-boot.dtsi in V2.

Best regards,
Ye Li


More information about the U-Boot mailing list