[U-Boot] [PATCH 1/1] cmd: add eficfg command

Heinrich Schuchardt xypron.glpk at gmx.de
Thu Jun 28 19:14:04 UTC 2018


On 06/28/2018 09:05 PM, Heinrich Schuchardt wrote:
> This relates to a patch in
> https://git.linaro.org/people/takahiro.akashi/u-boot.git
> branch efi/for_sct.
> 
> On 05/29/2018 08:47 AM, AKASHI Takahiro wrote:
> 
> Thanks for providing a possibility to edit EFI variables.
> 
> Before submitting, please, split the patch into a patch series.
> 
> E.g. moving definitions from cmd/bootefi.c to include/efi_loader.h could
> be in a separate patch.
> 
>> ---

<snip>

>> +
>> +static int show_efi_device_path(struct efi_device_path *dp0)
>> +{
>> +	char *type, *sub_type;
> 
> Please, reuse efi_convert_device_path_to_text().
> 

You can output a device path with
printf("%pD\n", device_path);

Missing nodes should be implemented in
lib/efi_loader/efi_device_path_to_text.c

Best regards

Heinrich


More information about the U-Boot mailing list