[U-Boot] [PATCH 1/2] arm: timer: factor out FSL arch timer erratum workaround

[Jagan Teki]

On Thu, Jun 28, 2018 at 8:07 PM, Andre Przywara <andre.przywara at arm.com> wrote:
> Hi,
>
> On 28/06/18 15:27, Jagan Teki wrote:
>> On Wed, Jun 27, 2018 at 6:12 AM, Andre Przywara <andre.przywara at arm.com> wrote:
>>> At the moment we have the workaround for the Freescale arch timer
>>> erratum A-008585 merged into the generic timer_read_counter() routine.
>>> Split those two up, so that we can add other errata workaround more
>>> easily. Also add an explaining comment on the way.
>>>
>>> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
>>> ---
>>>  arch/arm/cpu/armv8/generic_timer.c | 31 +++++++++++++++++++++++++------
>>>  1 file changed, 25 insertions(+), 6 deletions(-)
>>>
>>
>> Are these these two patches are for coming release?
>
> Yes, please. That's an issue that needs fixing now. The bug is in all
> A64 silicon, but the issue popped up with the recent commit 5ff8e54888e4
> and can be triggered quite easily:
> Boot mainline U-Boot on any A64 board, and do:
>> ls mmc 0:1
> on any SD card (with at least one partition defined). Then hold down the
> Enter key to repeat this last command over and over again. It usually
> takes less than 10 seconds to crash the board.
> People reported immediate crashes under certain circumstances (GPT
> partitioned SD cards):
> https://bugzilla.opensuse.org/show_bug.cgi?id=1098550

Yes I would able to reproduce the issue related to GPT partitions[1]
with SD card on BPI-M64 and seems like issue fixed[2] after applying
these two patches. I even tried another board in eMMC partition.

Tested-by: Jagan Teki <jagan at amarulasolutions.com>

[1] https://paste.ubuntu.com/p/hkHrQKXRj5/
[2] https://paste.ubuntu.com/p/JKrxC7ScNX/

Jagan.

-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.