[U-Boot] [PATCH] usb: ohci: change the NUM_EDs from 8 to 32

[Marek Vasut]

On 06/29/2018 11:47 AM, Zengtao (B) wrote:
> Hi Marek:
> 
>> -----Original Message-----
>> From: Marek Vasut [mailto:marex at denx.de]
>> Sent: Friday, June 29, 2018 4:50 PM
>> To: Zengtao (B) <prime.zeng at hisilicon.com>
>> Cc: u-boot at lists.denx.de
>> Subject: Re: [PATCH] usb: ohci: change the NUM_EDs from 8 to 32
>>
>> On 06/28/2018 07:54 PM, Zeng Tao wrote:
>>> For ohci, the maximam supported endpoint number is 32(in and out), and
>>> now we have used (usb_pipeendpoint(pipe) << 1) to index the specified
>>> endpoint descritor, usb_pipeendpoint(pipe) can reach 0xf, so we need
>>> change the NUM_EDs from 8 to 32.
>>>
>>> Signed-off-by: Zeng Tao <prime.zeng at hisilicon.com>
>>> ---
>>>  drivers/usb/host/ohci.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h index
>>> 2350831..fba78dc 100644
>>> --- a/drivers/usb/host/ohci.h
>>> +++ b/drivers/usb/host/ohci.h
>>> @@ -359,7 +359,7 @@ typedef struct
>>>  } urb_priv_t;
>>>  #define URB_DEL 1
>>>
>>> -#define NUM_EDS 8		/* num of preallocated endpoint descriptors */
>>> +#define NUM_EDS 32		/* num of preallocated endpoint
>> descriptors */
>>>
>>>  #define NUM_TD 64		/* we need more TDs than EDs */
>>
>> Is this a bugfix for some recent patch ?
> 
> Yes, this is a bugfix, but the issue is introduced more than 10years ago.

I presume this shows up on hisilicon soc then ?

Anyway, applied

-- 
Best regards,
Marek Vasut