[U-Boot] [PATCH] fw_printenv: Don't bail out directly after one env read error

[Wolfgang Denk]

Dear Joe,

In message <CANr=Z=atFzdNO6gNhMgopCHaQ-KXPGMfaOz2+_KCVrKwkMOhuw at mail.gmail.com> you wrote:
>
> > When using a redundant environment a read error should simply mean to
> > not use that copy instead of giving up completely. The other copy may
> > be just fine.
> >
> > Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> > Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu at ni.com>
> 
> Hey Tom, can you pull this in?

NO!  Please don't!!

NAK!!

This patch can lead to reading incorrect (old, no longer valid)
values without any way for the user to see what is happening.

This must not be done!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There is nothing  so  deadly  as  not  to  hold  up  to  people  the
opportunity to do great and wonderful things, if we wish to stimulate
them in an active way."
- Dr. Harold Urey, Nobel Laureate in chemistry