[U-Boot] fw_printenv: Don't bail out directly after one env read error

Wolfgang Denk wd at denx.de
Fri Jun 29 10:59:18 UTC 2018


Dear Tom,

In message <20180628022059.GR4609 at bill-the-cat.ec.rr.com> you wrote:
> 
> > From: Joe Hershberger <joe.hershberger at ni.com>
> >=20
> > When using a redundant environment a read error should simply mean to
> > not use that copy instead of giving up completely. The other copy may
> > be just fine.
> >=20
> > Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> > Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu at ni.com>
>
> Applied to u-boot/master, thanks!

Please revert.  This is introducing a source for nasty, almost
impossible to detect bugs!

Read errors must never be ignored.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What we anticipate seldom occurs;  what  we  least  expect  generally
happens.                                          - Bengamin Disraeli


More information about the U-Boot mailing list