[U-Boot] [PATCH v5 4/5] cmd: nvedit: env import can now import only variables passed as parameters

Wolfgang Denk wd at denx.de
Fri Jun 29 11:03:25 UTC 2018


Dear Quentin,

In message <322e6866c43f4515240ddca9456ee390b6f334c7.1530257385.git-series.quentin.schulz at bootlin.com> you wrote:
> While the `env export` can take as parameters variables to be exported,
> `env import` does not have such a mechanism of variable selection.
>
> Let's add the ability to add parameters at the end of the command for
> variables to be imported.

Thanks!

> If a variable exists in the current env but not in the imported env, if
> this variable is passed as a parameter to env import, the variable will
> be unset.

I suggest that this isNOT the default behaviour.  I think most
peaople would expect that this command only adds/replaces
environment settings, so omitting one value should not cause
unexpected behaviour.

But I agree that such behaviour may also be conveniend - I suggest
that we use an additional option ("-d" ?) to avtiavte it explicitly.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We want to create puppets that pull their own strings.   - Ann Marion


More information about the U-Boot mailing list