Hi Peng, On Thu, Nov 1, 2018 at 9:15 AM Peng Fan <peng.fan at nxp.com> wrote: > lseek only returns -1 when error. Is the coding style you proposed is preferred than > what this patch has? In case lseek changes someday to return something else, checking for (ret < 0) will still work, so it is a more robust error handling.