[U-Boot] [PATCH 08/13] mmc: tmio: Silence transfer errors when tuning

Masahiro Yamada yamada.masahiro at socionext.com
Fri Nov 2 03:59:40 UTC 2018


On Thu, Nov 1, 2018 at 9:14 PM Marek Vasut <marek.vasut at gmail.com> wrote:
>
> On 11/01/2018 12:42 PM, Masahiro Yamada wrote:
> > On Thu, Nov 1, 2018 at 2:22 AM Marek Vasut <marek.vasut at gmail.com> wrote:
> >>
> >> In case the controller performs card tuning, that is, sends MMC
> >> command 19 or 21, silence possible CRC error warning prints. The
> >> warnings are bound to happen, since the tuning will fail for some
> >> settings while searching for the optimal configuration of the bus
> >> and that is perfectly OK.
> >>
> >> This patch passes around the MMC command structure and adds check
> >> into tmio_sd_check_error() to avoid printing CRC error warning
> >> when the tuning happens.
> >
> > Make sense, but another solution might be
> > to delete the message entirely, or to turn it into a debug message.
>
> I'd like to see errors when they happen though, so what do you think
> about this patch ?


I am fine if you want to go with this patch.



-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list