[U-Boot] [PATCH v4 12/17] board_f: Use static print_cpuinfo if CONFIG_CPU is active

Bin Meng bmeng.cn at gmail.com
Sun Nov 4 14:18:19 UTC 2018


Hi Andy,

On Sun, Nov 4, 2018 at 4:51 AM Andy Shevchenko
<andy.shevchenko at gmail.com> wrote:
>
> On Sat, Nov 3, 2018 at 10:45 PM Andy Shevchenko
> <andy.shevchenko at gmail.com> wrote:
> >
> > On Fri, Oct 12, 2018 at 6:34 PM Bin Meng <bmeng.cn at gmail.com> wrote:
> > > On Fri, Oct 12, 2018 at 10:00 PM Stefan Roese <sr at denx.de> wrote:
> >
> > > diff --git a/arch/x86/cpu/baytrail/cpu.c b/arch/x86/cpu/baytrail/cpu.c
> > > index 56e9813..2eb9172 100644
> > > --- a/arch/x86/cpu/baytrail/cpu.c
> > > +++ b/arch/x86/cpu/baytrail/cpu.c
> > > @@ -203,4 +203,5 @@ U_BOOT_DRIVER(cpu_x86_baytrail_drv) = {
> > >         .bind           = cpu_x86_bind,
> > >         .probe          = cpu_x86_baytrail_probe,
> > >         .ops            = &cpu_x86_baytrail_ops,
> >
> > > +       .flags          = DM_FLAG_PRE_RELOC,
> >
> > This has to be done for all x86 boards I suppose?
> > Actually I don't see this in the v2018.11-rc3.
>
> Adding this to arch/x86/cpu/cpu_x86.c does NOT fix the problem!
>

This patch needs to be applied on top of u-boot-dm/master. I already
sent out email to Simon for PR for v2018.11.

> > >  }
> > >
> > > This patch needs to be applied on top of u-boot-x86/dm-fixes. Could
> > > you please have a try?
> > >
> > > I was not aware Mario's changes broke the Baytrail boards too! I was
> > > only testing on QEMU x86 before.
> >
> > Not only.
> > Edison board is broken by this patch.
> >
> > This must be fixed before release, or better just to revert the patch ASAP.
>
> Please, revert, if there is no quick cure.

Regards,
Bin


More information about the U-Boot mailing list