[U-Boot] [PATCH v3 06/18] clk: MediaTek: add clock driver for MT7629 SoC.
Ryder Lee
ryder.lee at mediatek.com
Mon Nov 5 08:06:32 UTC 2018
On Sat, 2018-11-03 at 00:08 -0600, Simon Glass wrote:
> Hi Ryder,
>
> On 2 November 2018 at 09:15, Ryder Lee <ryder.lee at mediatek.com> wrote:
> > This patch adds clock modules for MediaTek SoCs:
> > - Shared part: a common driver which contains the general operations
> > for plls, muxes, dividers and gates so that we can reuse it in future.
> >
> > - Specific SoC part: the group of structures used to hold the hardware
> > configuration for each SoC.
> >
> > We take MT7629 as an example to demonstrate how to implement driver if
> > any other MediaTek chips would like to use it.
> >
> > Signed-off-by: Ryder Lee <ryder.lee at mediatek.com>
> > ---
> > drivers/clk/Makefile | 1 +
> > drivers/clk/mediatek/Makefile | 6 +
> > drivers/clk/mediatek/clk-mt7629.c | 709 ++++++++++++++++++++++++++++++++++++++
> > drivers/clk/mediatek/clk-mtk.c | 492 ++++++++++++++++++++++++++
> > drivers/clk/mediatek/clk-mtk.h | 153 ++++++++
> > 5 files changed, 1361 insertions(+)
> > create mode 100644 drivers/clk/mediatek/Makefile
> > create mode 100644 drivers/clk/mediatek/clk-mt7629.c
> > create mode 100644 drivers/clk/mediatek/clk-mtk.c
> > create mode 100644 drivers/clk/mediatek/clk-mtk.h
>
> Please add coments to the structs and functions in the header file.
> Also put a _common prefix on the functions that are called from other
> files.
>
> Otherwise:
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Regards,
> Simon
Got it. I will send a new series soon.
Ryder
More information about the U-Boot
mailing list