[U-Boot] [PATCH v2 4/7] driver: net: ti: cpsw: update to use SPDX identifier

[Tom Rini]

On Tue, Nov 06, 2018 at 09:44:16AM +0530, Lokesh Vutla wrote:
> 
> 
> On Tuesday 06 November 2018 12:07 AM, Fabio Estevam wrote:
> >On Wed, Oct 31, 2018 at 4:07 PM Grygorii Strashko
> ><grygorii.strashko at ti.com> wrote:
> >>
> >>Update to use SPDX license identifier.
> >>
> >>Reviewed-by: Tom Rini <trini at konsulko.com>
> >>Acked-by: Joe Hershberger <joe.hershberger at ni.com>
> >>Signed-off-by: Grygorii Strashko <grygorii.strashko at ti.com>
> >>---
> >>  drivers/net/ti/cpsw.c | 12 ++----------
> >>  1 file changed, 2 insertions(+), 10 deletions(-)
> >>
> >>diff --git a/drivers/net/ti/cpsw.c b/drivers/net/ti/cpsw.c
> >>index 8e2a48c..fe43d14 100644
> >>--- a/drivers/net/ti/cpsw.c
> >>+++ b/drivers/net/ti/cpsw.c
> >>@@ -1,16 +1,8 @@
> >>+// SPDX-License-Identifier: GPL-2.0+
> >
> >Here you say GPL-2.0 or later...
> 
> why? Licenses/README says  GPL-2.0+ is a valid SPDX License Expression. Also
> rest of the u-boot files follow the same convention.
> 
> Thanks and regards,
> Lokesh
> 
> >
> >>  /*
> >>   * CPSW Ethernet Switch Driver
> >>   *
> >>- * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
> >>- *
> >>- * This program is free software; you can redistribute it and/or
> >>- * modify it under the terms of the GNU General Public License as
> >>- * published by the Free Software Foundation version 2.
> >
> >but the original license says GPL-2.0.
> >
> >so there is a mismatch between the SPDX and original license.

Ah, I think you both missed his point, sorry.  It's not about the format
of the tag but that the text is "GPL 2.0" and the tag is "GPL 2.0 or
later" instead of "GPL 2.0".  Now, can TI change the tag here?  Yes?
But, should we do it during the SPDX conversion rather than explicitly?
No, probably not.  At least not without a commit message being clear
it's intentional.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181105/5d8da912/attachment.sig>