[U-Boot] [PATCH 0/3] mtd: Fix partition handling code

[Boris Brezillon]

On Sat, 10 Nov 2018 16:57:07 +0530
Jagan Teki <jagan at amarulasolutions.com> wrote:

> On Sat, Nov 10, 2018 at 4:54 PM Boris Brezillon
> <boris.brezillon at bootlin.com> wrote:
> >
> > On Sat, 10 Nov 2018 15:02:05 +0530
> > Jagan Teki <jagan at amarulasolutions.com> wrote:
> >  
> > > On Mon, Nov 5, 2018 at 2:07 PM Jagan Teki <jagan at amarulasolutions.com> wrote:  
> > > >
> > > > On Wed, Oct 31, 2018 at 3:38 PM Boris Brezillon
> > > > <boris.brezillon at bootlin.com> wrote:  
> > > > >
> > > > > Hello,
> > > > >
> > > > > Stefan recently reported a bug when using ubi part on a spi-nand
> > > > > device and proposed this fix[1]. While his solution while working
> > > > > I proposed a different approach to kill the CMD_UBI dependency on
> > > > > CMD_MTDPARTS. This is what patches 1 and 2 are doing.
> > > > >
> > > > > Patch 3 is just removing the duplicate Kconfig MTD_PARTITIONS entry.
> > > > >
> > > > > Jagan, can you queue those patches to one of your branch and send a
> > > > > fixes PR, unless Tom prefers to take them directly.
> > > > >
> > > > > Regards,
> > > > >
> > > > > Boris
> > > > >
> > > > > Boris Brezillon (3):
> > > > >   mtd: Use default mtdparts/mtids when not defined in the environment
> > > > >   cmd: ubi: Remove useless call to mtdparts_init()
> > > > >   mtd: Drop duplicate MTD_PARTITIONS Kconfig option  
> > >
> > > Did you find this build issues? [1]
> > > https://travis-ci.org/openedev/u-boot-amarula/builds/450798634  
> >
> > If by find you mean notice, then no, but I just sent 2 patches to fix
> > the problems.
> >
> > Thanks for reporting the bugs.  
> 
> Look like enabling CMD_MTDPARTS=y to relevant defconfigs were fine,
> since other boards did the same. I made change trigger a build [2]

Well, there's still a problem with dependencies. For instance, DFU_NAND
should select CMD_MTDPARTS since it's using a function exposed by
cmd/mtdparts.c. For sure, adding CMD_MTDPARTS=y to existing defconfigs
does the trick, but it's not the correct fix IMHO.

> 
> [2] https://travis-ci.org/openedev/u-boot-amarula/builds/453235656