[U-Boot] [PATCH v2 1/5] mtd: Use default mtdparts/mtids when not defined in the environment

[Miquel Raynal]

Hi Jagan,

Jagan Teki <jagan at amarulasolutions.com> wrote on Mon, 12 Nov 2018
15:39:20 +0530:

> On Mon, Nov 12, 2018 at 2:54 PM Miquel Raynal <miquel.raynal at bootlin.com> wrote:
> >
> > Hi Boris, Tom,
> >
> > Boris Brezillon <boris.brezillon at bootlin.com> wrote on Mon, 12 Nov 2018
> > 09:28:05 +0100:
> >  
> > > U-boot provides a mean to define default values for mtdids and mtdparts
> > > when they're not defined in the environment. Patch mtd_probe_devices()
> > > to use those default values when env_get("mtdparts") or
> > > env_get("mtdids") return NULL.
> > >
> > > This implementation is based on the logic found in cmd/mtdparts.c.
> > >
> > > Fixes: 5db66b3aee6f ("cmd: mtd: add 'mtd' command")
> > > Reported-by: Stefan Roese <sr at denx.de>
> > > Signed-off-by: Boris Brezillon <boris.brezillon at bootlin.com>
> > > Tested-by: Stefan Roese <sr at denx.de>
> > > ---  
> >
> > For the whole series:
> >
> > Reviewed-by: Miquel Raynal <miquel.raynal at bootlin.com>
> >
> > This should be (if possible) in 2018.11, otherwise the release will be
> > buggy with certain configurations. Maybe we should sometimes send PR
> > directly to Tom as MTD is orphaned to avoid latencies between
> > developers/maintainers and reach mainline quickly (at least for the
> > fixes)?  
> 
> ie one of the reason I requesting travis-ci build before sending the
> generic changes.

Yes, we should have run a CI test first. I am not complaining at all
about the time between having the series posted and you testing it. I
understand this delay and really, I can't blame you for that. I'm just
saying that this is the second time we (almost?) miss a release because
of the additional delays between us, which are, IMHO, not really needed
while there is no actual code review as long as we do run Travis.


Thanks,
Miquèl