[U-Boot] [PATCH v2 4/5] cmd: ubi: Remove useless call to mtdparts_init()

[Lukasz Majewski]

On Mon, 12 Nov 2018 09:28:08 +0100
Boris Brezillon <boris.brezillon at bootlin.com> wrote:

> Commit c58fb2cdb3e4 ("cmd: ubi: clean the partition handling")
> introduced a call to mtd_probe_devices() in the ubi_attach() path
> and this function takes care of parsing mtdparts/mtdids and
> creating/registering the associated mtd partitions.
> 
> The mtdparts_init() call in the ubi_detach() path is not only
> unnecessary but can sometimes print error messages even when things
> work properly (that's the case with SPI NAND devices that have not
> been probed with 'mtd list'), which is misleading.
> 
> Remove this call to mtdparts_init() and drop the dependency on
> CMD_MTDPARTS.
> 
> Fixes: c58fb2cdb3e4 ("cmd: ubi: clean the partition handling")
> Reported-by: Stefan Roese <sr at denx.de>
> Signed-off-by: Boris Brezillon <boris.brezillon at bootlin.com>
> Tested-by: Stefan Roese <sr at denx.de>
> ---
> Changes in v2:
> - Moved after the patches reworking the Kconfig deps
> ---
>  cmd/Kconfig | 1 -
>  cmd/ubi.c   | 5 -----
>  2 files changed, 6 deletions(-)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 9310a8bdb2b7..ad14c9ce7124 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1856,7 +1856,6 @@ endmenu
>  
>  config CMD_UBI
>  	tristate "Enable UBI - Unsorted block images commands"
> -	select CMD_MTDPARTS
>  	select CRC32
>  	select MTD_UBI
>  	help
> diff --git a/cmd/ubi.c b/cmd/ubi.c
> index 767a4a453640..2b74a9814463 100644
> --- a/cmd/ubi.c
> +++ b/cmd/ubi.c
> @@ -417,11 +417,6 @@ static int ubi_dev_scan(struct mtd_info *info,
> const char *vid_header_offset) 
>  int ubi_detach(void)
>  {
> -	if (mtdparts_init() != 0) {
> -		printf("Error initializing mtdparts!\n");
> -		return 1;
> -	}
> -
>  #ifdef CONFIG_CMD_UBIFS
>  	/*
>  	 * Automatically unmount UBIFS partition when user

Reviewed-by: Lukasz Majewski <lukma at denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181112/6993aa82/attachment.sig>