[U-Boot] [PATCH] coreboot: only init usb if necessary

Christian Gmeiner christian.gmeiner at gmail.com
Mon Nov 12 14:39:19 UTC 2018


Hi Bin

Am Mo., 12. Nov. 2018 um 14:44 Uhr schrieb Bin Meng <bmeng.cn at gmail.com>:
>
> Hi Christian/Thomas,
>
> On Mon, Nov 12, 2018 at 8:44 PM Christian Gmeiner
> <christian.gmeiner at gmail.com> wrote:
> >
> > From: Thomas RIENOESSL <thomas.rienoessl at bachmann.info>
> >
> > Up until now the call to initialize the USB subsystem
> > was hardcoded for U-Boot running as a coreboot payload.
> > This was used to enable the use of a USB keyboard
> > in the U-Boot shell. However not all boards might need
> > this functionality. As initializing the USB subsystem
> > can take a considerable amount of time (several
> > seconds on some boards), we now initialize the
> > USB subsystem only if U-Boot is configured to use
> > USB keyboards.
> >
> > Signed-off-by: Thomas RIENOESSL <thomas.rienoessl at bachmann.info>
> > ---
> >  arch/x86/cpu/coreboot/coreboot.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
>
> Looks good to me. Can we also fix the efi-payload one?
>

Sure - do you prefer two patches (one for coreboot and one for x86:
efi: payload) or
shall we put both changes into one patch?

-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info


More information about the U-Boot mailing list