[U-Boot] [PATCH v2 1/5] mtd: Use default mtdparts/mtids when not defined in the environment

Boris Brezillon boris.brezillon at bootlin.com
Mon Nov 12 15:51:51 UTC 2018


On Mon, 12 Nov 2018 15:55:18 +0530
Jagan Teki <jagan at amarulasolutions.com> wrote:

> On Mon, Nov 12, 2018 at 1:58 PM Boris Brezillon
> <boris.brezillon at bootlin.com> wrote:
> >
> > U-boot provides a mean to define default values for mtdids and mtdparts
> > when they're not defined in the environment. Patch mtd_probe_devices()
> > to use those default values when env_get("mtdparts") or
> > env_get("mtdids") return NULL.
> >
> > This implementation is based on the logic found in cmd/mtdparts.c.
> >
> > Fixes: 5db66b3aee6f ("cmd: mtd: add 'mtd' command")
> > Reported-by: Stefan Roese <sr at denx.de>
> > Signed-off-by: Boris Brezillon <boris.brezillon at bootlin.com>
> > Tested-by: Stefan Roese <sr at denx.de>
> > ---
> > Changes in v2:
> > - none  
> 
> Trigger travis-ci [1], will send v2 PR once all built fine.
> 
> [1] https://travis-ci.org/openedev/u-boot-amarula/builds

Looks like mine is all green [1] ;-). And yes, now I have travis-ci
set up to track my u-boot repo, so hopefully I won't end up submitting
patches that regress the tests described in .travis.yaml in the future.
Still, I'd like to insist on that this test result shouldn't replace
human review, which I think is still valuable to spot subtle issues.

Also, I'd like to point that some of the failures caused by the
spi-nand patchset are actually coming from the weird way MTD related
config options are selected/defined in u-boot. This should probably be
simplified somehow, but that's a different story.

[1]https://travis-ci.org/bbrezillon/u-boot


More information about the U-Boot mailing list