[U-Boot] [PATCH V2 6/6] test: vboot: add padding pss for rsa signature

[Clément Péron]

Hi Philippe,

On Mon, 12 Nov 2018 at 18:41, Philippe REYNES
<philippe.reynes at softathome.com> wrote:
>
> Hi Clément,
>
> You're right, those its are in an old-format style.
> I can add a patch in this serie or send a separate
> patch to clean the style.
>
> What solution do you prefer ?
I'm not a maintainer but in this case I would have send a V3 if it's
not merged or send a separate patch if it's already merged.

If you send a V3, don't forget to add the "Reviewed-by" tags.

Regards,
Clement

>
> Regards,
> Philippe
>
>
> ----- Mail original -----
> De: "Clément Péron" <peron.clem at gmail.com>
> À: sjg at chromium.org
> Cc: "philippe reynes" <philippe.reynes at softathome.com>, "michal simek" <michal.simek at xilinx.com>, "joe hershberger" <joe.hershberger at ni.com>, "Marek Vasut" <marex at denx.de>, "yamada masahiro" <yamada.masahiro at socionext.com>, aford173 at gmail.com, "woods technical" <woods.technical at gmail.com>, "teddy reed" <teddy.reed at gmail.com>, "jun nie" <jun.nie at linaro.org>, "peng fan" <peng.fan at nxp.com>, "keguang zhang" <keguang.zhang at gmail.com>, "andre przywara" <andre.przywara at arm.com>, "philipp tomsich" <philipp.tomsich at theobroma-systems.com>, "bin chen" <bin.chen at linaro.org>, jsg at jsg.id.au, nomble at palism.com, swarren at nvidia.com, "paul burton" <paul.burton at mips.com>, "alex kiernan" <alex.kiernan at gmail.com>, "u-boot" <u-boot at lists.denx.de>
> Envoyé: Samedi 3 Novembre 2018 18:11:57
> Objet: Re: [PATCH V2 6/6] test: vboot: add padding pss for rsa signature
>
> Hi,
>
> I'm not an expert but regarding commit
> b8790ebeec13c882979dc986947397738d9f38aa I think you should drop the
> unit-address in its files.
>
> "    The DT spec demands a unit-address of a node name to match the "reg"
>     property in that node. Newer dtc versions will throw warnings if this is
>     not the case.
>     Fix all occurences in the FIT image example files where this was not
>     observed, to not give bad examples to the reader.
> "
>
> Regards,
> Clement
>
> On Sat, 3 Nov 2018 at 07:08, Simon Glass <sjg at chromium.org> wrote:
> >
> > On 25 October 2018 at 03:29, Philippe Reynes
> > <philippe.reynes at softathome.com> wrote:
> > > The padding pss is now supported for rsa signature.
> > > This add test with padding pss on vboot test.
> > >
> > > Signed-off-by: Philippe Reynes <philippe.reynes at softathome.com>
> > > ---
> > >  test/py/tests/test_vboot.py                     | 10 +++---
> > >  test/py/tests/vboot/sign-configs-sha1-pss.its   | 46 +++++++++++++++++++++++++
> > >  test/py/tests/vboot/sign-configs-sha256-pss.its | 46 +++++++++++++++++++++++++
> > >  test/py/tests/vboot/sign-images-sha1-pss.its    | 44 +++++++++++++++++++++++
> > >  test/py/tests/vboot/sign-images-sha256-pss.its  | 44 +++++++++++++++++++++++
> > >  5 files changed, 186 insertions(+), 4 deletions(-)
> > >  create mode 100644 test/py/tests/vboot/sign-configs-sha1-pss.its
> > >  create mode 100644 test/py/tests/vboot/sign-configs-sha256-pss.its
> > >  create mode 100644 test/py/tests/vboot/sign-images-sha1-pss.its
> > >  create mode 100644 test/py/tests/vboot/sign-images-sha256-pss.its
> > >
> > > Changelog:
> > > v2:
> > > - new patch in the serie
> > > - add vboot for pss padding (thanks Simon Glass)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>