[U-Boot] [PATCH 1/4] lib: lmb: reserving overlapping regions should fail
Simon Goldschmidt
simon.k.r.goldschmidt at gmail.com
Mon Nov 12 21:25:29 UTC 2018
lmb_add_region handles overlapping regions wrong: instead of merging
or rejecting to add a new reserved region that overlaps an existing
one, it just adds the new region.
Since internally the same function is used for lmb_alloc, change
lmb_add_region to reject overlapping regions.
Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
---
lib/lmb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/lmb.c b/lib/lmb.c
index 1705417348..8dc703d996 100644
--- a/lib/lmb.c
+++ b/lib/lmb.c
@@ -136,6 +136,9 @@ static long lmb_add_region(struct lmb_region *rgn, phys_addr_t base, phys_size_t
rgn->region[i].size += size;
coalesced++;
break;
+ } else if (lmb_addrs_overlap(base, size, rgnbase, rgnsize)) {
+ /* regions overlap */
+ return -1;
}
}
--
2.17.1
More information about the U-Boot
mailing list