[U-Boot] [PATCH v2 11/58] keymile: Unroll km/km83xx-common.h

[Holger Brunck]

Hi Mario,

> Simplify the keymile config files once more by unrolling the
> km/km83xx-common.h, and resolve the #ifdef logic as needed.
> 
> Signed-off-by: Mario Six <mario.six at gdsys.cc>
> 
> ---
> 
> v1 -> v2:
> No changes
> 
> ---
 > include/configs/km8360.h        | 291 ++++++++++++++++++++++++++++++++++++++-
 > include/configs/km83xx-common.h | 296 ----------------------------------------
 > include/configs/kmopti2.h       | 289 ++++++++++++++++++++++++++++++++++++++-
 > include/configs/kmsupx5.h       | 289 ++++++++++++++++++++++++++++++++++++++-
 > include/configs/kmtegr1.h       | 288 +++++++++++++++++++++++++++++++++++++-
 > include/configs/kmtepr2.h       | 289 ++++++++++++++++++++++++++++++++++++++-
 > include/configs/kmvect1.h       | 288 +++++++++++++++++++++++++++++++++++++-
 > include/configs/suvd3.h         | 291 ++++++++++++++++++++++++++++++++++++++-
 > include/configs/tuge1.h         | 289 ++++++++++++++++++++++++++++++++++++++-
 > include/configs/tuxx1.h         | 289 ++++++++++++++++++++++++++++++++++++++-
 > 10 files changed, 2579 insertions(+), 320 deletions(-)
 > delete mode 100644 include/configs/km83xx-common.h

could you elaborate why you need to do this? Turning 320 lines into 2579
does not sound like simplifying the code.  I understand that you
try to move a lot of config options to Kconfig for 83xx, which is good. But
why can't we keep common header files for things which are common for
some of our boards? For example duplicating CS configurations or SDRAM
settings for similar boards seems to be unneeded to me and increases
maintenance in the future.

Best regards
Holger Brunck