[U-Boot] [PATCH v4 14/18] serial: 16550: allow the driver to support MediaTek serial

Simon Glass sjg at chromium.org
Tue Nov 13 19:53:43 UTC 2018


Hi Ryder,

On 6 November 2018 at 01:47, Ryder Lee <ryder.lee at mediatek.com> wrote:
> This patch adds an extra operation in ns16550.c to suuport MediaTek
> SoCs as we have a highspeed register which influences the calcualtion
> of the divisor.
>
> Note that we don't support the baudrate greater than 115200 currently.
>
> Signed-off-by: Ryder Lee <ryder.lee at mediatek.com>
> Tested-by: Matthias Brugger <matthias.bgg at gmail.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> ---
> Changes since v4: None
>
> @Simon
> We have tried the compatible string, but it made the ns16550 driver more complicated.
> To use the compatible string we have to add a new field in ns16550_platdata, and change
> the flow of ns16550_serial_probe().
>
> Moreover, it's totally useless for debug uart. At present using a macro is the easiest way here.
>
> What do you think?
> ---
>  drivers/serial/ns16550.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Please see my reply to the other thread. We should not have
arch-specific code in generic drivers.

Sorry for not replying earlier on that.

Regards,
Simon


More information about the U-Boot mailing list