[U-Boot] [PATCH 1/1] efi_loader: eliminate sandbox addresses
Alexander Graf
agraf at suse.de
Tue Nov 13 19:58:16 UTC 2018
On 13.11.18 20:53, Simon Glass wrote:
> Hi Heinrich,
>
> On 10 November 2018 at 14:30, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>> Do not use the sandbox's virtual address space for the internal structures
>> of the memory map. This way we can eliminate a whole lot of unnecessary
>> conversions.
>>
>> The only conversion remaining is the one when adding known memory.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> ---
>> lib/efi_loader/efi_memory.c | 17 ++++-------------
>> 1 file changed, 4 insertions(+), 13 deletions(-)
>
> I much prefer this, but Alex was not too keen.
Uh, I thought you were the one who wanted to only expose fake addresses?
I think the patch is great as is :). It definitely simplifies the code.
> Also please can you add detailed comments to efi_mem_desc about what
> the addresses are for sandbox?
I'll wait for v2 then.
Alex
More information about the U-Boot
mailing list