[U-Boot] [PATCH 15/15] imx: add i.MX8MQ EVK support

[Peng Fan]

> -----Original Message-----
> From: Jon Nettleton [mailto:jon at solid-run.com]
> Sent: 2018年11月13日 15:53
> To: Troy Kisky <troy.kisky at boundarydevices.com>
> Cc: Peng Fan <peng.fan at nxp.com>; sbabic at denx.de; Fabio Estevam
> <fabio.estevam at nxp.com>; U-Boot Mailing List <u-boot at lists.denx.de>;
> dl-linux-imx <linux-imx at nxp.com>
> Subject: Re: [U-Boot] [PATCH 15/15] imx: add i.MX8MQ EVK support
> 
> On Fri, Nov 9, 2018 at 8:06 PM Troy Kisky <troy.kisky at boundarydevices.com>
> wrote:
> >
> > On 11/9/2018 1:17 AM, Peng Fan wrote:
> > > Add i.MX8MQ EVK support. SPL will initialize ddr and load ddr phy
> > > firmware. Then loading FIT image, ATF to OCRAM, U-Boot and DTB to
> > > DRAM....
> >
> >
> > > +
> > > +static struct dram_cfg_param lpddr4_ddrc_cfg[] = {
> > > +     /* Start to config, default 3200mbps */
> > > +     /* dis_dq=1, indicates no reads or writes are issued to SDRAM */
> > > +     { DDRC_DBG1(0), 0x00000001 },
> >
> >
> > Just a little elaboration on how a structure might work here
> >
> > #define DDRC_ADDR(reg, x) &((struct ddrc
> > *)(DDRC_IPS_BASE_ADDR(x))->reg)
> >
> >         { DDRC_ADDR(dbg1, 0), 0x00000001 },
> >
> >
> >
> > Thanks for working on this Peng!
> >
> >
> > BR
> > Troy
> 
> Yes thanks for working on this Peng.  Just to clarify one thing.  Do you have a
> script that is generating the structures from output of the mx8m_ddr_tool, or
> is the mx8m_ddr_tool being changed to output the structures?

Currently the i.MX8MQ ddr is still original format, not the format used in this patch.
When NXP GA software release, I think the ddr tool will support this new format. 

Regards,
Peng.


> 
> -Jon