[U-Boot] [PATCH 20/25] efi_loader: Don't enable in SPL/TPL by default

Alexander Graf agraf at suse.de
Wed Nov 14 13:28:00 UTC 2018


On 11/06/2018 11:21 PM, Simon Glass wrote:
> Generally this functionality is not useful in SPL or TPL. Update the
> Makefile so that it is not built.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>   lib/Makefile | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 4d2e22027d0..4dba3628e78 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -5,10 +5,10 @@
>   
>   ifndef CONFIG_SPL_BUILD
>   
> -obj-$(CONFIG_EFI) += efi/
> -obj-$(CONFIG_EFI_LOADER) += efi_driver/
> -obj-$(CONFIG_EFI_LOADER) += efi_loader/
> -obj-$(CONFIG_EFI_LOADER) += efi_selftest/
> +obj-$(CONFIG_$(SPL_TPL_)EFI) += efi/
> +obj-$(CONFIG_$(SPL_TPL_)EFI_LOADER) += efi_driver/
> +obj-$(CONFIG_$(SPL_TPL_)EFI_LOADER) += efi_loader/
> +obj-$(CONFIG_$(SPL_TPL_)EFI_LOADER) += efi_selftest/

This is already in the "ifndef CONFIG_SPL_BUILD" segment.

I'd rather like to see you remove that whole ifndef section including 
lzma, bzip2, tizen etc and convert (at least most of it) to the SPL_TPL_ 
magic you applied here.


Alex

>   obj-$(CONFIG_LZMA) += lzma/
>   obj-$(CONFIG_BZIP2) += bzip2/
>   obj-$(CONFIG_TIZEN) += tizen/




More information about the U-Boot mailing list