[U-Boot] [PATCH v2] spi: Zap fsl_espi driver-related code

York Sun york.sun at nxp.com
Wed Nov 14 15:53:00 UTC 2018


On 11/14/18 7:46 AM, Jagan Teki wrote:
> + Simon
> 
> On Wed, Nov 14, 2018 at 9:00 PM York Sun <york.sun at nxp.com> wrote:
>>
>> On 11/14/18 6:57 AM, Jagan Teki wrote:
>>> Dropped
>>> - fsl_espi driver
>>> - SPI, SPI flash CONFIG-items
>>> - CMD_SF..etc
>>>
>>> Dropped becuase
>>> - No proper changes related to since from 2015
>>> - no dm conversion.
>>>
>>> Cc: Tom Rini <trini at konsulko.com>
>>> Cc: York Sun <york.sun at nxp.com>
>>> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
>>> ---
>>> Note:
>>> - This certainly break many board, but it's too late
>>> - I have seen spi is using in net, mmc [1] will remove those
>>>   as well if none can answer this patch.
>>>
>>> [1] https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.org%2Fopenedev%2Fu-boot-amarula%2Fbuilds%2F454923826&data=02%7C01%7Cyork.sun%40nxp.com%7C5783a0a22ff84433058e08d64a485bb5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636778071970654553&sdata=q%2FXUyAdc6rvwSSOlTyxR2%2BlITFQn67EP9K1X5f6iM5o%3D&reserved=0
>>>
>>>  arch/powerpc/include/asm/config.h             |   2 +-
>>>  configs/B4420QDS_NAND_defconfig               |   5 -
>>>  configs/B4420QDS_SPIFLASH_defconfig           |   8 +-
>>>  configs/B4420QDS_defconfig                    |   5 -
>>>  configs/B4860QDS_NAND_defconfig               |   5 -
>>>  configs/B4860QDS_SECURE_BOOT_defconfig        |   5 -
>>>  configs/B4860QDS_SPIFLASH_defconfig           |   7 -
>>>  configs/B4860QDS_SRIO_PCIE_BOOT_defconfig     |   5 -
>>>  configs/B4860QDS_defconfig                    |   5 -
>>>  configs/BSC9131RDB_NAND_SYSCLK100_defconfig   |   5 -
>>>  configs/BSC9131RDB_NAND_defconfig             |   5 -
>>>  .../BSC9131RDB_SPIFLASH_SYSCLK100_defconfig   |   7 -
>>>  configs/BSC9131RDB_SPIFLASH_defconfig         |   7 -
>>>  ...BSC9132QDS_NAND_DDRCLK100_SECURE_defconfig |   4 -
>>>  configs/BSC9132QDS_NAND_DDRCLK100_defconfig   |   5 -
>>>  ...BSC9132QDS_NAND_DDRCLK133_SECURE_defconfig |   5 -
>>>  configs/BSC9132QDS_NAND_DDRCLK133_defconfig   |   5 -
>>>  .../BSC9132QDS_NOR_DDRCLK100_SECURE_defconfig |   5 -
>>>  configs/BSC9132QDS_NOR_DDRCLK100_defconfig    |   5 -
>>>  .../BSC9132QDS_NOR_DDRCLK133_SECURE_defconfig |   5 -
>>>  configs/BSC9132QDS_NOR_DDRCLK133_defconfig    |   5 -
>>>  ...C9132QDS_SDCARD_DDRCLK100_SECURE_defconfig |   5 -
>>>  configs/BSC9132QDS_SDCARD_DDRCLK100_defconfig |   5 -
>>>  ...C9132QDS_SDCARD_DDRCLK133_SECURE_defconfig |   5 -
>>>  configs/BSC9132QDS_SDCARD_DDRCLK133_defconfig |   5 -
>>>  ...132QDS_SPIFLASH_DDRCLK100_SECURE_defconfig |   6 -
>>>  .../BSC9132QDS_SPIFLASH_DDRCLK100_defconfig   |   7 -
>>>  ...132QDS_SPIFLASH_DDRCLK133_SECURE_defconfig |   6 -
>>>  .../BSC9132QDS_SPIFLASH_DDRCLK133_defconfig   |   7 -
>>>  configs/C29XPCIE_NAND_defconfig               |   6 -
>>>  configs/C29XPCIE_NOR_SECBOOT_defconfig        |   6 -
>>>  configs/C29XPCIE_SPIFLASH_SECBOOT_defconfig   |   7 -
>>>  configs/C29XPCIE_SPIFLASH_defconfig           |   8 -
>>>  configs/C29XPCIE_defconfig                    |   6 -
>>>  configs/Cyrus_P5020_defconfig                 |   2 -
>>>  configs/Cyrus_P5040_defconfig                 |   2 -
>>>  configs/MPC8536DS_36BIT_defconfig             |   5 -
>>>  configs/MPC8536DS_SDCARD_defconfig            |   5 -
>>>  configs/MPC8536DS_SPIFLASH_defconfig          |   7 -
>>>  configs/MPC8536DS_defconfig                   |   5 -
>>>  .../P1010RDB-PA_36BIT_NAND_SECBOOT_defconfig  |   5 -
>>>  configs/P1010RDB-PA_36BIT_NAND_defconfig      |   5 -
>>>  .../P1010RDB-PA_36BIT_NOR_SECBOOT_defconfig   |   5 -
>>>  configs/P1010RDB-PA_36BIT_NOR_defconfig       |   5 -
>>>  configs/P1010RDB-PA_36BIT_SDCARD_defconfig    |   5 -
>>>  ...010RDB-PA_36BIT_SPIFLASH_SECBOOT_defconfig |   6 -
>>>  configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig  |   9 -
>>>  configs/P1010RDB-PA_NAND_SECBOOT_defconfig    |   5 -
>>>  configs/P1010RDB-PA_NAND_defconfig            |   5 -
>>>  configs/P1010RDB-PA_NOR_SECBOOT_defconfig     |   5 -
>>>  configs/P1010RDB-PA_NOR_defconfig             |   5 -
>>>  configs/P1010RDB-PA_SDCARD_defconfig          |   5 -
>>>  .../P1010RDB-PA_SPIFLASH_SECBOOT_defconfig    |   6 -
>>>  configs/P1010RDB-PA_SPIFLASH_defconfig        |   9 -
>>>  .../P1010RDB-PB_36BIT_NAND_SECBOOT_defconfig  |   5 -
>>>  configs/P1010RDB-PB_36BIT_NAND_defconfig      |   5 -
>>>  .../P1010RDB-PB_36BIT_NOR_SECBOOT_defconfig   |   5 -
>>>  configs/P1010RDB-PB_36BIT_NOR_defconfig       |   5 -
>>>  configs/P1010RDB-PB_36BIT_SDCARD_defconfig    |   5 -
>>>  ...010RDB-PB_36BIT_SPIFLASH_SECBOOT_defconfig |   6 -
>>>  configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig  |   9 -
>>>  configs/P1010RDB-PB_NAND_SECBOOT_defconfig    |   5 -
>>>  configs/P1010RDB-PB_NAND_defconfig            |   5 -
>>>  configs/P1010RDB-PB_NOR_SECBOOT_defconfig     |   5 -
>>>  configs/P1010RDB-PB_NOR_defconfig             |   5 -
>>>  configs/P1010RDB-PB_SDCARD_defconfig          |   5 -
>>>  .../P1010RDB-PB_SPIFLASH_SECBOOT_defconfig    |   6 -
>>>  configs/P1010RDB-PB_SPIFLASH_defconfig        |   9 -
>>>  configs/P1020MBG-PC_36BIT_SDCARD_defconfig    |   2 -
>>>  configs/P1020MBG-PC_36BIT_defconfig           |   2 -
>>>  configs/P1020MBG-PC_SDCARD_defconfig          |   2 -
>>>  configs/P1020MBG-PC_defconfig                 |   2 -
>>>  configs/P1020RDB-PC_36BIT_NAND_defconfig      |   5 -
>>>  configs/P1020RDB-PC_36BIT_SDCARD_defconfig    |   5 -
>>>  configs/P1020RDB-PC_36BIT_SPIFLASH_defconfig  |   9 -
>>>  configs/P1020RDB-PC_36BIT_defconfig           |   5 -
>>>  configs/P1020RDB-PC_NAND_defconfig            |   5 -
>>>  configs/P1020RDB-PC_SDCARD_defconfig          |   5 -
>>>  configs/P1020RDB-PC_SPIFLASH_defconfig        |   9 -
>>>  configs/P1020RDB-PC_defconfig                 |   5 -
>>>  configs/P1020RDB-PD_NAND_defconfig            |   5 -
>>>  configs/P1020RDB-PD_SDCARD_defconfig          |   5 -
>>>  configs/P1020RDB-PD_SPIFLASH_defconfig        |   9 -
>>>  configs/P1020RDB-PD_defconfig                 |   5 -
>>>  configs/P1020UTM-PC_36BIT_SDCARD_defconfig    |   2 -
>>>  configs/P1020UTM-PC_36BIT_defconfig           |   2 -
>>>  configs/P1020UTM-PC_SDCARD_defconfig          |   2 -
>>>  configs/P1020UTM-PC_defconfig                 |   2 -
>>>  configs/P1021RDB-PC_36BIT_NAND_defconfig      |   5 -
>>>  configs/P1021RDB-PC_36BIT_SDCARD_defconfig    |   5 -
>>>  configs/P1021RDB-PC_36BIT_SPIFLASH_defconfig  |   9 -
>>>  configs/P1021RDB-PC_36BIT_defconfig           |   5 -
>>>  configs/P1021RDB-PC_NAND_defconfig            |   5 -
>>>  configs/P1021RDB-PC_SDCARD_defconfig          |   5 -
>>>  configs/P1021RDB-PC_SPIFLASH_defconfig        |   9 -
>>>  configs/P1021RDB-PC_defconfig                 |   5 -
>>>  configs/P1022DS_36BIT_NAND_defconfig          |   5 -
>>>  configs/P1022DS_36BIT_SDCARD_defconfig        |   5 -
>>>  configs/P1022DS_36BIT_SPIFLASH_defconfig      |   9 -
>>>  configs/P1022DS_36BIT_defconfig               |   5 -
>>>  configs/P1022DS_NAND_defconfig                |   5 -
>>>  configs/P1022DS_SDCARD_defconfig              |   5 -
>>>  configs/P1022DS_SPIFLASH_defconfig            |   9 -
>>>  configs/P1022DS_defconfig                     |   5 -
>>>  configs/P1024RDB_36BIT_defconfig              |   5 -
>>>  configs/P1024RDB_NAND_defconfig               |   5 -
>>>  configs/P1024RDB_SDCARD_defconfig             |   5 -
>>>  configs/P1024RDB_SPIFLASH_defconfig           |   9 -
>>>  configs/P1024RDB_defconfig                    |   5 -
>>>  configs/P1025RDB_36BIT_defconfig              |   5 -
>>>  configs/P1025RDB_NAND_defconfig               |   5 -
>>>  configs/P1025RDB_SDCARD_defconfig             |   5 -
>>>  configs/P1025RDB_SPIFLASH_defconfig           |   9 -
>>>  configs/P1025RDB_defconfig                    |   5 -
>>>  configs/P2020RDB-PC_36BIT_NAND_defconfig      |   5 -
>>>  configs/P2020RDB-PC_36BIT_SDCARD_defconfig    |   5 -
>>>  configs/P2020RDB-PC_36BIT_SPIFLASH_defconfig  |   9 -
>>>  configs/P2020RDB-PC_36BIT_defconfig           |   5 -
>>>  configs/P2020RDB-PC_NAND_defconfig            |   5 -
>>>  configs/P2020RDB-PC_SDCARD_defconfig          |   5 -
>>>  configs/P2020RDB-PC_SPIFLASH_defconfig        |   9 -
>>>  configs/P2020RDB-PC_defconfig                 |   5 -
>>>  configs/P2041RDB_NAND_defconfig               |   5 -
>>>  configs/P2041RDB_SDCARD_defconfig             |   5 -
>>>  configs/P2041RDB_SECURE_BOOT_defconfig        |   5 -
>>>  configs/P2041RDB_SPIFLASH_defconfig           |   8 +-
>>>  configs/P2041RDB_SRIO_PCIE_BOOT_defconfig     |   5 -
>>>  configs/P2041RDB_defconfig                    |   5 -
>>>  configs/P3041DS_NAND_SECURE_BOOT_defconfig    |   5 -
>>>  configs/P3041DS_NAND_defconfig                |   5 -
>>>  configs/P3041DS_SDCARD_defconfig              |   5 -
>>>  configs/P3041DS_SECURE_BOOT_defconfig         |   5 -
>>>  configs/P3041DS_SPIFLASH_defconfig            |   8 +-
>>>  configs/P3041DS_SRIO_PCIE_BOOT_defconfig      |   5 -
>>>  configs/P3041DS_defconfig                     |   5 -
>>>  configs/P4080DS_SDCARD_defconfig              |   5 -
>>>  configs/P4080DS_SECURE_BOOT_defconfig         |   5 -
>>>  configs/P4080DS_SPIFLASH_defconfig            |   8 +-
>>>  configs/P4080DS_SRIO_PCIE_BOOT_defconfig      |   5 -
>>>  configs/P4080DS_defconfig                     |   5 -
>>>  configs/P5020DS_NAND_SECURE_BOOT_defconfig    |   5 -
>>>  configs/P5020DS_NAND_defconfig                |   5 -
>>>  configs/P5020DS_SDCARD_defconfig              |   5 -
>>>  configs/P5020DS_SECURE_BOOT_defconfig         |   5 -
>>>  configs/P5020DS_SPIFLASH_defconfig            |   8 +-
>>>  configs/P5020DS_SRIO_PCIE_BOOT_defconfig      |   5 -
>>>  configs/P5020DS_defconfig                     |   5 -
>>>  configs/P5040DS_NAND_SECURE_BOOT_defconfig    |   5 -
>>>  configs/P5040DS_NAND_defconfig                |   5 -
>>>  configs/P5040DS_SDCARD_defconfig              |   5 -
>>>  configs/P5040DS_SECURE_BOOT_defconfig         |   5 -
>>>  configs/P5040DS_SPIFLASH_defconfig            |   8 +-
>>>  configs/P5040DS_defconfig                     |   5 -
>>>  configs/T1023RDB_NAND_defconfig               |   5 -
>>>  configs/T1023RDB_SDCARD_defconfig             |   5 -
>>>  configs/T1023RDB_SECURE_BOOT_defconfig        |   5 -
>>>  configs/T1023RDB_SPIFLASH_defconfig           |  10 +-
>>>  configs/T1023RDB_defconfig                    |   5 -
>>>  configs/T1024QDS_DDR4_SECURE_BOOT_defconfig   |   7 -
>>>  configs/T1024QDS_DDR4_defconfig               |   7 -
>>>  configs/T1024QDS_NAND_defconfig               |   7 -
>>>  configs/T1024QDS_SDCARD_defconfig             |   7 -
>>>  configs/T1024QDS_SECURE_BOOT_defconfig        |   7 -
>>>  configs/T1024QDS_SPIFLASH_defconfig           |  12 +-
>>>  configs/T1024QDS_defconfig                    |   7 -
>>>  configs/T1024RDB_NAND_defconfig               |   5 -
>>>  configs/T1024RDB_SDCARD_defconfig             |   5 -
>>>  configs/T1024RDB_SECURE_BOOT_defconfig        |   5 -
>>>  configs/T1024RDB_SPIFLASH_defconfig           |  10 +-
>>>  configs/T1024RDB_defconfig                    |   5 -
>>>  configs/T1040D4RDB_NAND_defconfig             |   5 -
>>>  configs/T1040D4RDB_SDCARD_defconfig           |   5 -
>>>  configs/T1040D4RDB_SECURE_BOOT_defconfig      |   5 -
>>>  configs/T1040D4RDB_SPIFLASH_defconfig         |  10 +-
>>>  configs/T1040D4RDB_defconfig                  |   5 -
>>>  configs/T1040QDS_DDR4_defconfig               |   7 -
>>>  configs/T1040QDS_SECURE_BOOT_defconfig        |   7 -
>>>  configs/T1040QDS_defconfig                    |   7 -
>>>  configs/T1040RDB_NAND_defconfig               |   5 -
>>>  configs/T1040RDB_SDCARD_defconfig             |   5 -
>>>  configs/T1040RDB_SECURE_BOOT_defconfig        |   5 -
>>>  configs/T1040RDB_SPIFLASH_defconfig           |  10 +-
>>>  configs/T1040RDB_defconfig                    |   5 -
>>>  configs/T1042D4RDB_NAND_defconfig             |   5 -
>>>  configs/T1042D4RDB_SDCARD_defconfig           |   5 -
>>>  configs/T1042D4RDB_SECURE_BOOT_defconfig      |   5 -
>>>  configs/T1042D4RDB_SPIFLASH_defconfig         |  10 +-
>>>  configs/T1042D4RDB_defconfig                  |   5 -
>>>  .../T1042RDB_PI_NAND_SECURE_BOOT_defconfig    |   5 -
>>>  configs/T1042RDB_PI_NAND_defconfig            |   5 -
>>>  configs/T1042RDB_PI_SDCARD_defconfig          |   5 -
>>>  configs/T1042RDB_PI_SPIFLASH_defconfig        |  10 +-
>>>  configs/T1042RDB_PI_defconfig                 |   5 -
>>>  configs/T1042RDB_SECURE_BOOT_defconfig        |   5 -
>>>  configs/T1042RDB_defconfig                    |   5 -
>>>  configs/T2080QDS_NAND_defconfig               |   7 -
>>>  configs/T2080QDS_SDCARD_defconfig             |   7 -
>>>  configs/T2080QDS_SECURE_BOOT_defconfig        |   7 -
>>>  configs/T2080QDS_SPIFLASH_defconfig           |  12 +-
>>>  configs/T2080QDS_SRIO_PCIE_BOOT_defconfig     |   7 -
>>>  configs/T2080QDS_defconfig                    |   7 -
>>>  configs/T2080RDB_NAND_defconfig               |   5 -
>>>  configs/T2080RDB_SDCARD_defconfig             |   5 -
>>>  configs/T2080RDB_SECURE_BOOT_defconfig        |   5 -
>>>  configs/T2080RDB_SPIFLASH_defconfig           |  10 +-
>>>  configs/T2080RDB_SRIO_PCIE_BOOT_defconfig     |   5 -
>>>  configs/T2080RDB_defconfig                    |   5 -
>>>  configs/T2081QDS_NAND_defconfig               |   7 -
>>>  configs/T2081QDS_SDCARD_defconfig             |   7 -
>>>  configs/T2081QDS_SPIFLASH_defconfig           |  12 +-
>>>  configs/T2081QDS_SRIO_PCIE_BOOT_defconfig     |   7 -
>>>  configs/T2081QDS_defconfig                    |   7 -
>>>  configs/T4160QDS_NAND_defconfig               |   5 -
>>>  configs/T4160QDS_SDCARD_defconfig             |   5 -
>>>  configs/T4160QDS_SECURE_BOOT_defconfig        |   5 -
>>>  configs/T4160QDS_defconfig                    |   5 -
>>>  configs/T4160RDB_defconfig                    |   5 -
>>>  configs/T4240QDS_NAND_defconfig               |   5 -
>>>  configs/T4240QDS_SDCARD_defconfig             |   5 -
>>>  configs/T4240QDS_SECURE_BOOT_defconfig        |   5 -
>>>  configs/T4240QDS_SRIO_PCIE_BOOT_defconfig     |   5 -
>>>  configs/T4240QDS_defconfig                    |   5 -
>>>  configs/T4240RDB_SDCARD_defconfig             |   5 -
>>>  configs/T4240RDB_defconfig                    |   5 -
>>>  configs/TWR-P1025_defconfig                   |   2 -
>>>  configs/UCP1020_SPIFLASH_defconfig            |  11 -
>>>  configs/UCP1020_defconfig                     |   9 -
>>>  ...trolcenterd_36BIT_SDCARD_DEVELOP_defconfig |   5 -
>>>  configs/controlcenterd_36BIT_SDCARD_defconfig |   5 -
>>>  configs/kmcoge4_defconfig                     |   7 -
>>>  configs/kmlion1_defconfig                     |   7 -
>>>  drivers/spi/Kconfig                           |   7 -
>>>  drivers/spi/Makefile                          |   1 -
>>>  drivers/spi/fsl_espi.c                        | 388 ------------------
>>>  include/configs/BSC9131RDB.h                  |   6 -
>>>  include/configs/BSC9132QDS.h                  |  10 -
>>>  236 files changed, 17 insertions(+), 1723 deletions(-)
>>>  delete mode 100644 drivers/spi/fsl_espi.c
>>>
>>
>> NAK. This breaks most mpc85xx boards. If you use DM as the reason, I
>> cannot stop you.
> 
> Been waited with initial patch, but no response either. Any timeline
> for DM conversion?
> 

I know. I forwarded to internal R&D team but I didn't hear any feedback.
I will probably drag this as long as possible, until non-DM drivers are
dropped, or someone steps up to convert those drivers.

York


More information about the U-Boot mailing list