[U-Boot] [PATCH v2 2/5] serial: ns16550: Read reg-io-width from device tree

Andy Shevchenko andy.shevchenko at gmail.com
Thu Nov 15 19:53:23 UTC 2018


On Thu, Nov 15, 2018 at 9:47 PM Simon Glass <sjg at chromium.org> wrote:
> On 15 November 2018 at 09:58, Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
> > Cache the value of the reg-io-width property for the future use.

> >         plat->reg_offset = dev_read_u32_default(dev, "reg-offset", 0);
> >         plat->reg_shift = dev_read_u32_default(dev, "reg-shift", 0);
> > +       plat->reg_width = dev_read_u32_default(dev, "reg-io-width", 1);
> >
>
> Is your intent to actually use this for something? It sounds good, as
> at present we have all the horrible #ifdefs.

Not in this series.
Here is just an implementation (enough for SPCR case) of Bin's proposal.

> > -       int clock;
> >         int reg_offset;
> > +       int clock;
>
> Should be in a separate patch.

Yes, if we conclude something about date structures. Otherwise don't
mind I won't touch it.

-- 
With Best Regards,
Andy Shevchenko


More information about the U-Boot mailing list