[U-Boot] [PATCH v12 1/6] sandbox: Put CPUs under a cpu-bus node

Alexander Graf agraf at suse.de
Thu Nov 15 20:05:49 UTC 2018



On 15.11.18 21:01, Simon Glass wrote:
> Hi Alex,
> 
> On 14 November 2018 at 00:34, Alexander Graf <agraf at suse.de> wrote:
>> On 11/06/2018 11:57 PM, Simon Glass wrote:
>>>
>>> The CPU uclass expects that all CPUs have a parent device which is a
>>> cpu-bus. Fix up the sandbox test DT to follow this convention. This allow
>>> the code in smbios_write_type4_dm() to work, since it calls
>>> dev_get_parent_platdata() on each CPU.
>>>
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>
>>
>> This patch breaks the built-in unit tests:
>>
>> => ut dm cpu
>> Test: dm_test_cpu: cpu.c
>> test/dm/cpu.c:28, dm_test_cpu(): 0 == uclass_get_device_by_name(UCLASS_CPU,
>> "cpu-test1", &dev): Expected 0, got -19
>> Test: dm_test_cpu: cpu.c (flat tree)
>> test/dm/cpu.c:28, dm_test_cpu(): 0 == uclass_get_device_by_name(UCLASS_CPU,
>> "cpu-test1", &dev): Expected 0, got -19
>> Failures: 2
>>
>>
>> I'll remove it from my queue again.
> 
> Yes unfortunately there was a revert on master which affected this I think.
> 
> I can pick this one up once things land.

I'd appreciate that, yes, thanks :).


Alex


More information about the U-Boot mailing list