[U-Boot] [PATCH] serial: ns16550: add setconfig support

[Simon Glass]

Hi,

On 16 November 2018 at 09:04, Simon Goldschmidt
<simon.k.r.goldschmidt at gmail.com> wrote:
>
>
> Am Sa., 3. Nov. 2018, 08:56 hat Simon Goldschmidt
> <simon.k.r.goldschmidt at gmail.com> geschrieben:
>>
>> On 03.11.2018 07:08, Simon Glass wrote:
>> > On 2 November 2018 at 14:28, Simon Goldschmidt
>> > <simon.k.r.goldschmidt at gmail.com> wrote:
>> >> Add possibility to update the serial parity used.
>> >>
>> >> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
>> >> ---
>> >>
>> >>   drivers/serial/ns16550.c | 43
>> >> ++++++++++++++++++++++++++++++++++++++--
>> >>   1 file changed, 41 insertions(+), 2 deletions(-)
>> >>
>> > Reviewed-by: Simon Glass <sjg at chromium.org>
>> >
>> > Ideally we should call this from sandbox (or a test) somewhere.
>>
>> Hmm, I'm a bit lost there. I haven't really used the tests so far and
>> grep'ing through test/ does not show any reference to ns16550 either
>> (where I could easily add a test).
>>
>> Did you mean adding a test for this specific driver (ns16550) or for the
>> call to 'setconfig' in general? (Because I thought Patrice had already
>> done that.)
>
>
> Simon, any input on this? Does your comment somehow hold back this from
> being pushed?

No, I added my review tag.

It looks like serial_setconfig() is written without a struct udevice
parameter. I think that should be fixed, since new functionality
should use DM.

Regards,
Simon