[U-Boot] [PATCH] RFC: checkpatch: Add a check for tests needed for uclasses

Simon Glass sjg at chromium.org
Sun Nov 18 15:16:54 UTC 2018


This is an experimental check for adding new uclasses without a test.

I am not sure of the best way to add U-Boot-specific tests, although in
this case, it would not fire on Linux.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 scripts/checkpatch.pl | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 373094e59ef..2f9edb429d5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3033,6 +3033,13 @@ sub process {
 			     "adding a line without newline at end of file\n" . $herecurr);
 		}
 
+		# ask for a test if a new uclass ID is added
+		if ($realfile =~ /uclass-id.h/ && $line =~ /^\+/) {
+			WARN("NEW_UCLASS",
+			     "Possible new uclass - make sure to add a test in test/dm/<name>.c\n" . $herecurr);
+		}
+
+
 # check we are in a valid source file C or perl if not then ignore this hunk
 		next if ($realfile !~ /\.(h|c|pl|dtsi|dts)$/);
 
-- 
2.19.1.1215.g8438c0b245-goog



More information about the U-Boot mailing list