[U-Boot] [PATCH 1/2] core: ofnode: Fix ofnode_get_addr_size_index function

Simon Glass sjg at chromium.org
Sun Nov 18 21:29:52 UTC 2018


Hi Keerthy,

On Fri, 16 Nov 2018 at 17:09, Simon Glass <sjg at chromium.org> wrote:
>
> On Tue, 13 Nov 2018 at 12:53, Simon Glass <sjg at chromium.org> wrote:
> >
> > On 4 November 2018 at 22:47, Keerthy <j-keerthy at ti.com> wrote:
> > > Currently the else part of ofnode_get_addr_size_index function
> > > does not fetch addresses based on the index but rather just
> > > returns the base address. Fix that.
> > >
> > > Signed-off-by: Keerthy <j-keerthy at ti.com>
> > > ---
> > >  drivers/core/ofnode.c | 13 ++++++++-----
> > >  1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > This should really have a sandbox test, e.g. see
> > dm_test_fdt_remap_addr_flat,() for a test that relies on flagtree.
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Unfortunately this patch causes build errors with sandbox. Can you
please take a look? I skip the second patch in this series too, since
it depends on this one.

Regards,
Simon


More information about the U-Boot mailing list