[U-Boot] Re : Re: Re : Re: [PATCH] exynos5: allow bigger BL2 (u-boot.bin)

[Tom Rini]

On Mon, Nov 19, 2018 at 06:03:45PM +0100, Guillaume GARDET wrote:
 
> ----- Tom Rini <trini at konsulko.com> a écrit :
> > On Mon, Nov 19, 2018 at 05:56:37PM +0100, Guillaume GARDET wrote:
> > > 
> > > ----- Tom Rini <trini at konsulko.com> a écrit :
> > > > On Mon, Nov 19, 2018 at 05:45:03PM +0100, Guillaume GARDET wrote:
> > > > 
> > > > > This patch allows SPL to load a bigger BL2 (u-boot.bin).
> > > > > This is needed for and has been tested on Arndale board, as u-boot.bin is 
> > > > > now bigger than 512K with GCC8.
> > > > > 
> > > > > Signed-off-by: Guillaume GARDET <guillaume.gardet at free.fr>
> > > > > 
> > > > > Cc: Minkyu Kang <mk7.kang at samsung.com>
> > > > > Cc: Tom Rini <trini at konsulko.com>
> > > > > ---
> > > > >  include/configs/exynos5-common.h | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > Are these platforms using thumb2 to build?  Were it not for some early
> > > > Cortex-A platforms with thumb2 errata I'd be strongly inclined to do a
> > > > global switch to making that option default.
> > > 
> > > No, they are not using thumb2:
> > > # CONFIG_SYS_THUMB_BUILD is not set
> > > # CONFIG_SPL_SYS_THUMB_BUILD is not set
> > 
> > I would suggest switching that on instead then.  I'm always wary of
> > changing stuff on the flash layout.
> 
> I tested thumb2 for SPL and u-boot.bin on arndale and it does boot properly.
> u-boot.bin is 397KB with thumb2, which is OK.
> 
> Should I make the switch for Arndale board only, or on a bigger range?

I'd go ahead and switch all exynos platforms.  My recollection is it's
really only very old / early Cortex-A platforms with issues and I'm
pretty sure we either have the appropriate errata enabled or they've all
been discarded at this point in time.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181119/2d89500b/attachment.sig>