[U-Boot] [PATCH v14 0/4] efi_loader: Code refactoring and improvement

[Heinrich Schuchardt]

On 11/19/18 2:49 AM, Simon Glass wrote:
> Hi Heinrich,
> 
> On Sun, 18 Nov 2018 at 08:20, Simon Glass <sjg at chromium.org> wrote:
>>
>> Hi Alex,
>>
>> On Wed, 14 Nov 2018 at 16:11, Simon Glass <sjg at chromium.org> wrote:
>>>
>>> This collects the patches previously sent to break up the very large
>>> functions in efi_loader into smaller pieces. Now that the other sandbox
>>> stuff is applied, perhaps it is time to apply these patches.
>>>
>>> This also adds a few new patches to fix more recent breakages.
>>> Unfortunately we still cannot enable the efi loader tests since one of
>>> the tests fails. Thus we should expect additional failures to appear
>>> until that is resolved.
>>>
>>> Changes in v14:
>>> - Fix condition for invalid pointer
>>> - Go back to the horrible long variable names
>>> - Hopefully correct error paths in do_bootefi_exec()
>>
>> Any thoughts on this series please?
> 
> Could you please take another look at this? I would very much like to
> put it to bed.
> 
> Regards,
> Simon
> 

Refactoring into shorter functions makes sense to me.

The errors I mentioned in the review comments for the individual patches
were not introduced by you but we should not simply copy but correct them.

Best regards

Heinrich