[U-Boot] [PATCH v3 1/5] usb: Introduce CONFIG_SPL_DM_USB

[Sven Schwermer]

Hi Marek,

>> This allows building the SPL without driver model for USB. Since
>> CONFIG_SPL_DM_USB is enabled if and only if CONFIG_DM_USB was enabled
>> before, this patch does not change the build behaviour.
>> 
>> Signed-off-by: Sven Schwermer <sven at svenschwermer.de>
> 
> I asked before, but shouldn't this be 5/5 ?

Here are the reasons why I don’t think so:
1) This particular order doesn’t break any builds. I triggered Travis CI runs for every patch in order and they have all succeeded.
2) Before this patch series, DM was enabled for both SPL and proper when setting CONFIG_DM_USB=y. If I had done the s/CONFIG_DM_USB/CONFIG_IS_ENABLED(DM_USB)/ step before this patch, the DM would have suddenly been disabled for _all_ boards in their SPL builds. That would have definitively changed the existing behaviour. By doing it this way (CONFIG_SPL_DM_USB depends on CONFIG_DM_USB and the default for the former is “y”), IMHO nothing changes.

I have difficulties seeing any advantages doing this patch last.

Best regards,
Sven