[U-Boot] [PATCH v3 2/5] usb: am335x_evm: Disable CONFIG_SPL_DM_USB

[Marek Vasut]

On 11/20/2018 03:10 PM, Sven Schwermer wrote:
> 
>>> Well, since CONFIG_SPL_DM_USB depends on SPL_DM_USB, I don’t think that’s the case.
>>
>> Are you _sure_ ? Sorry if I'm being hard, but this affects a lot of
>> users, so I have to be cautious.
> 
> I am _not_ sure. That’s why I used the verb “think” ;-) I’m sorry, but I don’t think I can provide the guarantees you need. How can we investigate this systematically?

I think you can just run make $board_defconfig for all boards (I don't
think you need toolchain to do that) and verify that the option didn't
get enabled in the resulting .config .

>>>> btw I don't think SPL_DM_USB should depend on DM_USB , one is for SPL
>>>> and the other for U-Boot.
>>>
>>> Aha! There are two reasons I did this:
>>> 1) I used CONFIG_SPL_DM_MMC as the inspiration for my changes. That one depends on CONFIG_DM_MMC.
>>
>> I don't think that's right. SPL and U-Boot are separate things.
> 
> Agreed.
> 
>>> 2) In order to not break a lot of configs, see above.
>>>
>>> If this is unacceptable for you, I guess, I’ll have to revisit this. That’d make this series a lot bigger I think. Tell me your preference.
>>
>> I don't mind bigger and better series, but let's just answer the
>> question first.
> 
> I’m just afraid, that this is more likely to break existing boards.

Let's see :)

-- 
Best regards,
Marek Vasut