[U-Boot] [PATCH v7 00/11] [RESEND] Add support for DM_USB and DM_USB_DEV for TI's DRA7 EVMs and AM57 EVMs platforms.

Jean-Jacques Hiblot jjhiblot at ti.com
Tue Nov 20 15:20:51 UTC 2018


On 20/11/2018 12:38, Lukasz Majewski wrote:
> Hi,
>
>> Hi Jean-Jacques,
>>
>>> Resending this series after rebasing on top of latest u-boot.
>>> This series applies on top of the series "[PATCH v3 0/7]
>>> Improvements for the dwc3_generic driver"
>>>
>>> Moving to DM_USB and DM_USB_DEV brings some benefits:
>>> - it is required to support DM_ETH and USB network adapters with the
>>> same binary.
>>> - support for USB3 on AM57x comes almost for free
>>> - removal of platform code related to USB
>>>
>>> Tested on:
>>> - dra76 evm
>>> - AM572 evm
>>>    
>> I've tried to merge and test your patches:
>> SHA1: 0c4b382f9041f9f2f00246c8a0ece90dae5451be
>> https://github.com/lmajewski/u-boot-dfu/commits/testing
>>
> The updated repository is the same as above (SHA1 is of course
> different)
>
>> The results from Travis-CI:
>> https://travis-ci.org/lmajewski/u-boot-dfu/jobs/456736504
> https://travis-ci.org/lmajewski/u-boot-dfu/builds/457229385
>
> The "buildman" rockchip build breaks after applying your patches.
>
> https://travis-ci.org/lmajewski/u-boot-dfu/jobs/457229443
>
>> It breaks for e.g. OMAP.
>>
>> Could you check this problem and resubmit patches?
> Am I missing any more patches? Or maybe you have a Travis-CI "clean"
> branch/repo somewhere so I could use it ?
>
The error is legit. It must have been caused by a recent change.

It  fails because CONFIG_TPL_LOGLEVEL is not set....

It means that dev_dbg(), and dev_... printout functions cannot be used 
within the TPL. I'm surprised that it hasn't been seen before.

A simple fix is to add a definition for TPL_LOG_LEVEL in the Kconfig

diff --git a/common/Kconfig b/common/Kconfig
index d7300c2..949dba4 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -290,6 +290,10 @@ config SPL_LOGLEVEL
         int
         default LOGLEVEL

+config TPL_LOGLEVEL
+       int
+       default LOGLEVEL
+

There is a patch from Simon that does that and much more '[PATCH v3 
01/21] spl: Add support for logging in SPL and TPL'. Can you try with 
this patch ?


>> Thanks in advance,
>> Łukasz
>>
>>> Changes in v7:
>>> - replace remaining if() statements with ut_assert()
>>> - Fix build issue "multiple definition of
>>> `usb_gadget_handle_interrupts'"
>>> - Fixed build issue "multiple definition of
>>> `usb_gadget_handle_interrupts'"
>>>
>>> Changes in v6:
>>> - ti-pipe3-phy: take PLL out of IDLE in pipe3_init(). The PLL may
>>> have been put into idle by pipe3_exit()
>>> - DRA7 configs: enable DM_USB and DM_USB_DEV. Use DWC3_GENERIC in
>>> place of DWC3_OF_SIMPLE. disable non DM USB options
>>> - AM57 configs: enable DM_USB and DM_USB_DEV. Use DWC3_GENERIC in
>>> place of DWC3_OF_SIMPLE. disable non DM USB options
>>> - Supports DM USB for peripherals
>>> - Removed DTS changes that disabled USB1 on DRA7 because DM_USB_DEV
>>> is now supported
>>>
>>> Changes in v5:
>>> - Rebased on latest u-boot
>>> - Removed patches that have already been merged
>>>
>>> Changes in v4:
>>> - Fix word missing in commit log
>>> - Remove dependency on MISC
>>> - Renamed the commit (DM_USB is already enabled, the only missing
>>> option is for the USB2 phy driver)
>>> - Remove dependency on MISC
>>> - Remove omap specific glue layer and use dwc3-of-simple glue layer
>>>
>>> Changes in v3:
>>> - in syscon_regmap_lookup_by_phandle(), use dev_dbg() instead of
>>> printf()
>>> - added unit test for syscon_regmap_lookup_by_phandle()
>>>
>>> Changes in v2:
>>> - Add USB3 support to ti-pipe3-phy driver
>>> - omap-usb2-phy: Implement power_on and power_off callbacks
>>> - am57xx boards: when DM_USB is used, turn on the required USB
>>> clocks
>>> - split dts changes in 2 commits: one for binding the children of
>>>    ocp2scp at 4a080000, and one to disable USB1  on all DRA7 EVMs
>>> - Enable DM_USB in am57xx_evm_defconfig. USB3 (super speed) is
>>> supported.
>>>
>>> Jean-Jacques Hiblot (9):
>>>    syscon: dm: Add a new method to get a regmap from DTS
>>>    phy: Add a new driver for OMAP's USB2 PHYs
>>>    dwc3-generic: Add support for the TI DWC3 glue
>>>    board: ti: dra7xx-evm: turn on USB clocks in late init stage
>>>    dts: dra7x: make ocp2scp at 4a080000 compatible with simple-bus
>>>    configs: enable DM_USB and DM_USB_DEV for all DRA7 platforms
>>>    configs: am57xx_evm: Enable DM_USB and DM_USB_DEV
>>>    board: ti: dra7-evm: remove USB platform code
>>>    board: ti: am57xx: remove USB platform code
>>>
>>> Vignesh R (2):
>>>    phy: ti-pip3-phy: Add support for USB3 PHY
>>>    board; ti: am57xx: turn on USB clocks
>>>
>>>   arch/arm/dts/omap5-u-boot.dtsi  |   4 +
>>>   arch/sandbox/dts/test.dts       |   6 +-
>>>   board/ti/am57xx/board.c         | 106 ++++------------------
>>>   board/ti/dra7xx/evm.c           | 123 ++++---------------------
>>>   configs/am57xx_evm_defconfig    |  10 +-
>>>   configs/am57xx_hs_evm_defconfig |  10 +-
>>>   configs/dra7xx_evm_defconfig    |   8 +-
>>>   configs/dra7xx_hs_evm_defconfig |   8 +-
>>>   drivers/core/syscon-uclass.c    |  23 +++++
>>>   drivers/phy/Kconfig             |   9 ++
>>>   drivers/phy/Makefile            |   1 +
>>>   drivers/phy/omap-usb2-phy.c     | 196
>>> ++++++++++++++++++++++++++++++++++++++++
>>> drivers/phy/ti-pipe3-phy.c      |  32 +++++--
>>> drivers/usb/dwc3/dwc3-generic.c |  85 +++++++++++++++++
>>> include/syscon.h                |  13 +++
>>> test/dm/syscon.c                |  29 ++++++ 16 files changed, 448
>>> insertions(+), 215 deletions(-) create mode 100644
>>> drivers/phy/omap-usb2-phy.c
>>>    
>>
>>
>>
>> Best regards,
>>
>> Lukasz Majewski
>>
>> --
>>
>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
>> lukma at denx.de
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de


More information about the U-Boot mailing list