[U-Boot] [PATCH v3 1/5] usb: Introduce CONFIG_SPL_DM_USB
Marek Vasut
marex at denx.de
Tue Nov 20 15:48:26 UTC 2018
On 11/20/2018 04:30 PM, Sven Schwermer wrote:
> Hi,
>
>> On 20 Nov 2018, at 14:32, Marek Vasut <marex at denx.de> wrote:
>>
>> On 11/20/2018 02:27 PM, Sven Schwermer wrote:
>>>>> Here are the reasons why I don’t think so:
>>>>> 1) This particular order doesn’t break any builds. I triggered Travis CI runs for every patch in order and they have all succeeded.
>>>>> 2) Before this patch series, DM was enabled for both SPL and proper when setting CONFIG_DM_USB=y.
>>>>
>>>> Are you sure about this ? I recall boards which built SPL without DM and
>>>> U-Boot with DM USB.
>>>
>>> Well I’m not very experienced contributing to u-boot, this is a first, so I’m not certain.
>>
>> You sure picked an awesome topic for your first contribution :-) This is
>> certainly not an easy change.
>
> So it seems.
>
>>> However, that was my train of thought.
>>> If you have a concrete defconfig I should check, I can do so.
>>
>> dh_imx6 for example.
>
> The generated .config is identical before and after the patch series for this board. It also compiles fine after the patch series.
Good, so no USB support in SPL ?
--
Best regards,
Marek Vasut
More information about the U-Boot
mailing list