[U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

Andy Shevchenko andy.shevchenko at gmail.com
Tue Nov 20 17:39:56 UTC 2018


On Thu, Nov 15, 2018 at 12:22:31PM -0800, Simon Glass wrote:
> On 15 November 2018 at 11:51, Andy Shevchenko <andy.shevchenko at gmail.com> wrote:
> > On Thu, Nov 15, 2018 at 9:46 PM Simon Glass <sjg at chromium.org> wrote:
> >> On 15 November 2018 at 09:58, Andy Shevchenko
> >> <andriy.shevchenko at linux.intel.com> wrote:

> >> > +int serial_getinfo(struct serial_device_info *info)
> >>
> >> This should use driver model, so:
> >>
> >> int serial_getinfo(struct udevice *dev, struct serial_device_info *info)
> >
> > Oh, sure!

I have to withdraw this comment based on two points:
- the rest of API is using it in this way
- it is all about current console IIUC, so, anyway we would need the same code to retrieve it

Are you still thinking that serial_getinfo(dev, info) would be preferable?

-- 
With Best Regards,
Andy Shevchenko




More information about the U-Boot mailing list