[U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

[Andy Shevchenko]

On Wed, Nov 21, 2018 at 12:04 AM Alexander Graf <agraf at suse.de> wrote:
> On 20.11.18 19:32, Andy Shevchenko wrote:
> > On Thu, Nov 15, 2018 at 11:45:32AM -0800, Simon Glass wrote:
> >> On 15 November 2018 at 09:58, Andy Shevchenko
> >> <andriy.shevchenko at linux.intel.com> wrote:

> >>> +       u64     addr;
> >>
> >> ulong
> >
> > This, unfortunately, will not work. ACPI takes the address as 32-bit halves,
> > and shift to 32 on 32-bit platform is UB.
>
> I guess what Simon wanted to get to is more something like "phys_addr_t"
> which actually tells you what the variable is supposed to transfer.
>
> Keep in mind that this is only for interim data. You can put this into a
> u64 before putting it into the ACPI table inside your ACPI specific code
> just fine.

I have learned today that U-Boot inherited lower_32_bits() and upper_32_bits()
macros, so, I use ulong.

-- 
With Best Regards,
Andy Shevchenko