[U-Boot] [PATCH v2 3/3] riscv: Add S-mode defconfigs for QEMU virt machine

[Anup Patel]

On Tue, Nov 20, 2018 at 7:09 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Tue, Nov 20, 2018 at 7:29 PM Anup Patel <anup at brainfault.org> wrote:
> >
> > This patch adds S-mode defconfigs for QEMU virt machine so
> > that we can run u-boot in S-mode on QEMU using M-mode runtime
> > firmware (BBL or equivalent).
> >
> > Signed-off-by: Anup Patel <anup at brainfault.org>
> > ---
> >  configs/qemu-riscv32-smode_defconfig | 10 ++++++++++
> >  configs/qemu-riscv64-smode_defconfig | 11 +++++++++++
>
> nits: please use the name: qemu-riscv*_smode_defconfig (_ instead of -)

OK, I will update filename of defconfigs

>
> >  2 files changed, 21 insertions(+)
> >  create mode 100644 configs/qemu-riscv32-smode_defconfig
> >  create mode 100644 configs/qemu-riscv64-smode_defconfig
> >
>
> Please update board/emulation/qemu-riscv/MAINTAINERS to include these
> 2 defconfigs, otherwise buildman will report warnings.

Sure, I will update MAINTAINERS file.

>
> Other than that,
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> Tested-by: Bin Meng <bmeng.cn at gmail.com>
>

Thanks,
Anup