[U-Boot] [PATCH 18/21] log: Check printf() arguments

Simon Glass sjg at chromium.org
Sat Nov 24 04:29:41 UTC 2018


At present logging does not check printf() arguments. Now that all users
have been corrected, enable this to prevent further problems.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 include/log.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/log.h b/include/log.h
index 4f14937b7a2..310b2cf7ce5 100644
--- a/include/log.h
+++ b/include/log.h
@@ -73,7 +73,8 @@ static inline int log_uc_cat(enum uclass_id id)
  * @return 0 if log record was emitted, -ve on error
  */
 int _log(enum log_category_t cat, enum log_level_t level, const char *file,
-	 int line, const char *func, const char *fmt, ...);
+	 int line, const char *func, const char *fmt, ...)
+		__attribute__ ((format (__printf__, 6, 7)));
 
 /* Define this at the top of a file to add a prefix to debug messages */
 #ifndef pr_fmt
-- 
2.20.0.rc0.387.gc7a69e6b6c-goog



More information about the U-Boot mailing list