[U-Boot] [PATCH] arm64: mvebu: fix crash in EFI memory allocation

Stephen Warren swarren at wwwdotorg.org
Mon Nov 26 16:51:04 UTC 2018


On 11/22/18 8:19 AM, Baruch Siach wrote:
> Hi Alex,
> 
> Adding Stephen Warren to Cc.
> 
> On Thu, Nov 22, 2018 at 02:30:34PM +0000, Alexander Graf wrote:
>>> Am 22.11.2018 um 11:42 schrieb Baruch Siach <baruch at tkos.co.il>:
>>>
>>> EFI memory allocation code return values that are not mapped by U-Boot
>>> MMU. This causes a crash when tftp calls efi_set_bootdev(). Fix this
>>> similarly to commit 0797f7f0b7e1 ("ARM: tegra: reserve unmapped RAM so
>>> EFI doesn't use it").
>>>
>>> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
>>
>> Hm, how about we fox this up in the common memory registration function and
>> add addresses > board_get_usable_ram_top() as boot time data?
> 
> That would be much nicer indeed. Where should I look in lib/efi_loader/ to
> implement that?
> 
> With that in place we can revert commit 0797f7f0b7e1, right? Stephen, do you
> concur?

I believe so, yes. I'm not sure why it's acceptable to fix the EFI 
allocator to solve this now, when it wasn't acceptable before though.


More information about the U-Boot mailing list