[U-Boot] [PATCH v3 1/7] dm: serial: Add ->getconfig() callback

[Simon Glass]

Hi Andy,

On Tue, 20 Nov 2018 at 14:52, Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> In some cases it would be good to know the settings, such as parity,
> of current serial console. One example might be an ACPI SPCR table
> to generate using these parameters.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---
>  drivers/serial/sandbox.c       | 13 +++++++++++++
>  drivers/serial/serial-uclass.c | 16 ++++++++++++++++
>  include/common.h               |  1 +
>  include/serial.h               | 26 +++++++++++++++++++++++---
>  test/dm/serial.c               |  7 +++++++
>  5 files changed, 60 insertions(+), 3 deletions(-)
>

My only concern is that serial_get_config() should have a device parameter.

Regards,
Simon