[U-Boot] [PATCH 6/7] arm: mvebu: helios4: Enable SPI flash support

[Aditya Prayoga]

On Wed, Nov 28, 2018 at 9:10 PM Baruch Siach <baruch at tkos.co.il> wrote:
>
> Hi Dennis,
>
> On Wed, Nov 28, 2018 at 07:53:44AM -0600, Dennis Gilmore wrote:
> > On Wed, 2018-11-28 at 17:00 +0800, Aditya Prayoga wrote:
> > > Enable SPI flash support under U-Boot and SPL. The ENV size and
> > > offset,
> > > ported from U-Boot 2013.01 Marvell version: 2015_T1.0p16
> > >
> > > To create U-Boot image for SPI flash, user would need to replace
> > > * CONFIG_MVEBU_SPL_BOOT_DEVICE_MMC with
> > > CONFIG_MVEBU_SPL_BOOT_DEVICE_SPI
> > > * CONFIG_ENV_IS_IN_MMC with CONFIG_ENV_IS_IN_SPI_FLASH
> > >
> > > Signed-off-by: Aditya Prayoga <aditya at kobol.io>
> > > ---
> > >  arch/arm/dts/armada-388-helios4.dts |  7 +++++++
> > >  configs/helios4_defconfig           |  1 -
> > >  include/configs/helios4.h           | 31
> > > +++++++++++++++++++++++++++++++
> > >  3 files changed, 38 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/dts/armada-388-helios4.dts
> > > b/arch/arm/dts/armada-388-helios4.dts
> > > index 711fc22..cd3fcae 100644
> > > --- a/arch/arm/dts/armada-388-helios4.dts
> > > +++ b/arch/arm/dts/armada-388-helios4.dts
> > > @@ -26,6 +26,7 @@
> > >             ethernet1 = &eth0;
> > >             i2c0 = &i2c0;
> > >             i2c1 = &i2c1;
> > > +           spi1 = &spi1;
> > has this gone upstream to the kernel?
> > >     };
> > >
> > >     chosen {
> > > @@ -244,6 +245,7 @@
> > >                                          &microsom_spi1_cs_pins>;
> > >                             pinctrl-names = "default";
> > >                             status = "okay";
> > > +                           u-boot,dm-spl;
> > there is a method in u-boot that needs to be used where u-boot specific
> > snippets go into a <dtb file nane>-u-boot.dts file, I am struggling to
> > find the documentation on it, perhaps someone else can point us both at
> > it.
>
> See tools/binman/README under "Automatic .dtsi inclusion".
Thanks for the pointer

Aditya

> Would have been nice to be able to add u-boot.dtsi onto another .dtsi. That
> would have saved us from copying the content of
> armada-388-clearfog-u-boot.dtsi over and over for each board that carries the
> same SOM. Maybe we can use a symlink for that? It's a little less ugly than
> copy.
>
> baruch
>
> > >                     };
> > >
> > >                     sdhci at d8000 {
> > > @@ -308,3 +310,8 @@
> > >             };
> > >     };
> > >  };
> > > +
> > > +&w25q32 {
> > > +   status = "okay";
> > > +   u-boot,dm-spl;
> > > +};
> > same as above the u-boot bit should go in a armada-388-helios4-u-
> > boot.dts file and the generic bits in the upstream kernel dts file.
> >
> > Dennis
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -