[U-Boot] [PATCHv2 1/4] dm: MIGRATION: Add migration plan for DM_MMC

[Tom Rini]

On Thu, Nov 29, 2018 at 09:10:50PM +0100, Simon Goldschmidt wrote:
> On 29.11.2018 21:02, Tom Rini wrote:
> >On Thu, Nov 29, 2018 at 08:51:17PM +0100, Simon Goldschmidt wrote:
> >>On 29.11.2018 20:12, Tom Rini wrote:
> >>>Given that at this point the MMC subsystem itself has been migrated
> >>>along with a number of subsystem drivers, formalize a deadline for
> >>>migration.
> >>>
> >>>Cc: Simon Glass <sjg at chromium.org>
> >>>Cc: Jaehoon Chung <jh80.chung at samsung.com>
> >>>Signed-off-by: Tom Rini <trini at konsulko.com>
> >>>---
> >>>Changes in v2:
> >>>- Note that failure to migration may lead to removal.
> >>>---
> >>>  Makefile                       | 8 ++++++++
> >>>  doc/driver-model/MIGRATION.txt | 9 +++++++++
> >>>  2 files changed, 17 insertions(+)
> >>>
> >>>diff --git a/Makefile b/Makefile
> >>>index a4b1d1db5241..0ab48f9ac97f 100644
> >>>--- a/Makefile
> >>>+++ b/Makefile
> >>>@@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
> >>>  	@echo "before sending patches to the mailing list."
> >>>  	@echo "===================================================="
> >>>  endif
> >>>+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
> >>This might not be a too widespread use of U-Boot, but I do have one
> >>configuration that boots from FPGA and loads Linux via TFTP. Due to size
> >>constraints in FPGA onchip RAM, I have MMC disabled completely. This patch
> >>gives me a warning in this case.
> >>
> >>I can live with that as I know I have MMC disabled and don't this warning
> >>for my other configs though. Just wanted to let you know, as you complained
> >>about getting no replies to this thread ;-)
> >Ah, thanks.  That means I should have put a test for CONFIG_MMC in there
> >somewhere.  I need to re-work the USB one too I think to confirm
> >CONFIG_USB is set.  Thanks!  I'll post a v3 once I've given folks a
> >chance in general to chime in with this having re-hit their inbox.
> 
> And you're right, I get the same problem for USB, which I have always
> disabled on our boards. But with CONFIG_USB, it's more clear to be than with
> CONFIG_MMC. Maybe CONFIG_DM_MMC should depend on CONFIG_MMC?

I suspect a small re-work to the Kconfig file to turn MMC into a
menuconfig so that everything else is grouped under it would help, yes.
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181129/9a409ce4/attachment.sig>