[U-Boot] [PATCH] pico-imx7d: Increase the CONFIG_ENV_OFFSET size

[Stefano Babic]

Hi Wolfgang,

On 30/11/18 14:05, Wolfgang Denk wrote:
> Dear Fabio,
> 
> In message <1543571315-6376-1-git-send-email-festevam at gmail.com> you wrote:
>> The environment size has grown in such a way that it corrupts the
>> main U-Boot image after a "saveenv" causing a U-Boot hang.
>>
>> Fix this problem by increasing the CONFIG_ENV_OFFSET size.
> 
> Sorry, I can't understand this change.
> 
>>  /* FLASH and environment organization */
>>  #define CONFIG_ENV_SIZE			SZ_8K
>>  
>> -#define CONFIG_ENV_OFFSET			(8 * SZ_64K)
>> +#define CONFIG_ENV_OFFSET			(12 * SZ_64K)
> 
> The size written to flash should never exceed CONFIG_ENV_SIZE; if it
> does, then there is some serious bug in the code, which I tend to
> doubt.
> 
> And when the environment grows,

This was V1. It is not the size of the environment, it is U-Boot that
grows and has overflow into the environment, leading to corruption by
the first saveenv.

Nevertheless, the initial offset (0x80000) was quite optimistic with
current bootloader size - u-boot binary for i.MX is often > 512KB.

> it would make it necessary to raise
> CONFIG_ENV_SIZE first

No.

> - changing the CONFIG_ENV_OFFSET has nothing
> to do with this per se.
> 
> Can you please explain which phenomenon you see, and hos this change
> is supposed to work?

Best regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================