[U-Boot] [PATCH 0/6] Migrate BOUNCE_BUFFER

Simon Goldschmidt simon.k.r.goldschmidt at gmail.com
Fri Nov 30 13:55:18 UTC 2018


[cut down CC list as gmail won't let me send to that many people :-( ]

Am 30.11.2018 um 12:39 schrieb Philipp Tomsich:
> A number of MMC drivers uses BOUNCE_BUFFER for their DMA buffers.
> This moves it into Kconfig and performs a step-by-step migration for
> the affected boards/drivers.
>
> In doing so, it turns out that a few boards/configs enabled
> CONFIG_BOUNCE_BUFFER in their config headers without an apparent need.
> The migration (using moveconfig) for those boards is kept in a
> separate patch, so it can be more easily reviewed by the affected
> parties to make a determination whether it is actually needed.
>
> Given that BOUNCE_BUFFER only controls whether the bounce_buffer_*
> functions are build and linked, this configuration option could be
> entirely removed and the utility functions built unconditionally.  For
> platforms that don't make use of these functions, the linker will then
> remove the unused symbols.
>
> I'll leave the final decision if this would be a better implementation
> (or if this should be done in a two-stage process) to someone else...
> END.

I think this is a good idea, but I get build errors after applying patch 
2/6 since CONFIG_BOUNCE_BUFFER is now enabled via Kconfig and defined as 
1 while at the same time it is just defined (but to nothing) in 
socfpga_common.h.

Can you change or reorder this series so that every commit compiles?

Regards,

Simon

> Philipp Tomsich (6):
>    Kconfig: Migrate BOUNCE_BUFFER
>    mmc: dw_mmc: depend on BOUNCE_BUFFER
>    mmc: mxsmmc: select BOUNCE_BUFFER unconditionally
>    mmc: tegra: select BOUNCE_BUFFER unconditionally
>    arc: select BOUNCE_BUFFER for CMD_NAND on AXS10x
>    Kconfig: migrate BOUNCE_BUFFER (final moveconfig)
>
>   arch/arc/Kconfig                          | 2 ++
>   common/Kconfig                            | 8 ++++++++
>   configs/bcm911360_entphn-ns_defconfig     | 1 +
>   configs/bcm911360_entphn_defconfig        | 1 +
>   configs/bcm911360k_defconfig              | 1 +
>   configs/bcm958300k-ns_defconfig           | 1 +
>   configs/bcm958300k_defconfig              | 1 +
>   configs/bcm958305k_defconfig              | 1 +
>   configs/bcm958622hr_defconfig             | 1 +
>   configs/socfpga_arria10_defconfig         | 1 +
>   drivers/mmc/Kconfig                       | 3 +++
>   include/configs/axs10x.h                  | 5 -----
>   include/configs/bcm_ep_board.h            | 3 ---
>   include/configs/emsdp.h                   | 3 ---
>   include/configs/exynos-common.h           | 3 ---
>   include/configs/hikey.h                   | 3 ---
>   include/configs/hsdk.h                    | 5 -----
>   include/configs/iot_devkit.h              | 3 ---
>   include/configs/mx6_common.h              | 1 -
>   include/configs/mx7_common.h              | 1 -
>   include/configs/mx7ulp_evk.h              | 1 -
>   include/configs/mxs.h                     | 5 -----
>   include/configs/poplar.h                  | 3 ---
>   include/configs/rk3036_common.h           | 2 --
>   include/configs/rk3128_common.h           | 3 ---
>   include/configs/rk3188_common.h           | 3 ---
>   include/configs/rk322x_common.h           | 3 ---
>   include/configs/rk3288_common.h           | 3 ---
>   include/configs/rk3328_common.h           | 3 ---
>   include/configs/rk3368_common.h           | 2 --
>   include/configs/rk3399_common.h           | 1 -
>   include/configs/socfpga_common.h          | 1 -
>   include/configs/socfpga_stratix10_socdk.h | 1 -
>   include/configs/tegra-common.h            | 3 ---
>   scripts/config_whitelist.txt              | 1 -
>   35 files changed, 21 insertions(+), 62 deletions(-)
>



More information about the U-Boot mailing list