[U-Boot] [PULL] Please pull u-boot-imx

[Stefano Babic]

On 02/09/2018 19:11, Tom Rini wrote:
> On Sun, Sep 02, 2018 at 07:06:06PM +0200, Stefano Babic wrote:
>>
>>
>> On 01/09/2018 13:37, Tom Rini wrote:
>>> On Fri, Aug 31, 2018 at 03:04:31PM +0200, Stefano Babic wrote:
>>>
>>>> Hi Tom,
>>>>
>>>> please pull from u-boot-imx, thanks !
>>>>
>>>> The following changes since commit 11ed312896c5f5814064c5d45dcb2f53dc121437:
>>>>
>>>>   configs: am57xx: change default board name to beagle_x15 (2018-08-26
>>>> 12:26:16 -0400)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>   git://www.denx.de/git/u-boot-imx.git master
>>>>
>>>> for you to fetch changes up to 2846e663fd62200a189bba357135e284a379a38b:
>>>>
>>>>   imx: missing CONFIG_MII in mx7dsabresd_qspi_defconfig (2018-08-31
>>>> 12:08:43 +0200)
>>>>
>>>
>>> OK, NAK for the following problems:
>>> - Fail to build: https://travis-ci.org/trini/u-boot/jobs/423197300
>>>   The failing board is ids8313 and it's failing to configure as
>>>   CONFIG_SYS_BOOTCOUNT_I2C_BUS needs to be set, and isn't
>>
>> It looks wrong how I verify the whole build. Running buildman on my
>> host, all boards were built. I will
> 
> That's odd.  Are you building the world, or just arm? 

I am building i.MX, that could be the cause:

./tools/buildman/buildman imx mx25 mx27 mx31 mx35 mxs mx5 mx6 mx7 vf610


> I noticed this
> since my non-travis world build got stuck and then confirmed it just
> trying to build that single PowerPC board.

ok

> 
>>> - In looking into the above I see configs/ge_bx50v3_defconfig and
>>>   configs/mx53ppd_defconfig and a few more have a bunch of comments
>>>   added to it.  These will be blown away on the next re-sync.  Comments
>>>   need to go into the board README or something not an auto-generated
>>>   file.
>>
>> I saw this, but if the board maintainer won't use "make savedefonfig" to
>> generate its own defconfig, I have not blocked this if this lead to a
>> successful build.
> 
> It needs to be a rejection error, I try and remember to re-sync all of
> the defconfigs at least before the final release and if I'm doing it
> right, before the -rcs too.

ok

> 
>>> - So I start reading the whole diff and I see:
>>> commit 8e00d802e402d2a6734a88ebeb77a70efcfc354c
>>> Author: Sébastien Szymanski <sebastien.szymanski at armadeus.com>
>>> Date:   Wed Jul 25 14:47:53 2018 +0200
>>>
>>>     ARM: opos6ul: make the board boot again
>>>
>>> Which is wrong.  The -u-boot.dtsi file is automatically included and
>>> should have all of the U-Boot specific DTS changes.
>>
>> I have to understand why my build was successful...
> 
> It's not a fatal problem, it's just not doing things the right way.
> 
>>> - And since the above big real problems exist I'm going to point out for
>>>   you to fix:
>>> WARNING: no status info for 'mx7dsabresd_qspi'
>>> WARNING: no maintainers for 'mx7dsabresd_qspi'
>>>
>>
>> Note this, they will be fixed.
> 
> Fabio posted a patch for this one BTW.

Thanks, I pick it up.

Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================