[U-Boot] [PATCH 02/13] pico-imx6ul: Convert to SPL

Michael Nazzareno Trimarchi michael at amarulasolutions.com
Mon Sep 3 13:05:18 UTC 2018


Hi Fabio

On Mon, Sep 3, 2018 at 3:01 PM Fabio Estevam <festevam at gmail.com> wrote:
>
> Hi Jagan,
>
> On Sun, Sep 2, 2018 at 3:07 PM, Jagan Teki <jagan at amarulasolutions.com> wrote:
>
> >> --- /dev/null
> >> +++ b/board/technexion/pico-imx6ul/spl.c
> >> @@ -0,0 +1,115 @@
> >> +// SPDX-License-Identifier: GPL-2.0+
> >
> > space
> >
>
> >> +static void ccgr_init(void)
> >> +{
> >> +       struct mxc_ccm_reg *ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
> >> +
> >> +       writel(0xFFFFFFFF, &ccm->CCGR0);
> >> +       writel(0xFFFFFFFF, &ccm->CCGR1);
> >> +       writel(0xFFFFFFFF, &ccm->CCGR2);
> >> +       writel(0xFFFFFFFF, &ccm->CCGR3);
> >> +       writel(0xFFFFFFFF, &ccm->CCGR4);
> >> +       writel(0xFFFFFFFF, &ccm->CCGR5);
> >> +       writel(0xFFFFFFFF, &ccm->CCGR6);
> >> +       writel(0xFFFFFFFF, &ccm->CCGR7);

are you sure that arrive to 7?

> >
> > These can be know values.
>
> I am sorry, but I did not understand your comments.
>

I think that it's not a good strategy to enable all the gate in general here.

Michael

> Please clarify.
>
> Thanks
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |


More information about the U-Boot mailing list