[U-Boot] [PATCH 3/4] console: unify fgetc function when console MUX is deactivated

Patrick DELAUNAY patrick.delaunay at st.com
Mon Sep 3 14:56:36 UTC 2018


Hi Simon,

> From: sjg at google.com <sjg at google.com> On Behalf Of Simon Glass
> Sent: mercredi 8 août 2018 11:56
> To: Patrick DELAUNAY <patrick.delaunay at st.com>
> On 3 August 2018 at 05:38, Patrick Delaunay <patrick.delaunay at st.com> wrote:
> > Unify the fgetc function when MUX is activated or not:
> > - always call tstc() : it is the normal behavior expected
> >   by serial uclass (call tstc then getc) and that avoids
> >   issue when SERIAL_RX_BUFFER is activated
> > - reload WATCHDOG in the char waiting loop
> >
> > This patch allow to have the same behavior when CONSOLE_MUX is
> > activated or not and avoid regression when this feature is deactivated.
> >
> > Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> > ---
> >
> >  common/console.c | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> I'm not sure how to test this with the various cases...

Yes it is a difficully and I don't know the process in this case,
but at least the behavior (testc() function call) will be shared.

If this change seens too risky, it can be dropped as only the PATCH 1/4 is mandatory to solve my issue.

Regards, Patrick


More information about the U-Boot mailing list