[U-Boot] [PATCH v4] usb: ehci-generic: Add vbus-supply regulator support

Patrice CHOTARD patrice.chotard at st.com
Tue Sep 4 07:33:12 UTC 2018


Hi Marek

On 09/03/2018 06:16 PM, Marek Vasut wrote:
> On 09/03/2018 03:39 PM, Patrice Chotard wrote:
>> Add vbus-supply regulator support.
>> On some board vbus is not controlled by the phy but by
>> an external regulator.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
>> ---
>>
>> Changes in v4:
>>        - Remove useless dev->name in dev_dgb()
> 
> Two remaining nits, can you pull the regulator handling into separate
> functions and put ifdef arounds those, with empty default
> implementation? That way, the ifdefs won't be spread throughout the code.

Agree it will be more readable.

> 
> Also, rebase on u-boot-usb/master please.

Ok

Thanks

Patrice

> 


More information about the U-Boot mailing list